Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallbackLocales to false causing unexpected behaviour #1123

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

Shinyaigeek
Copy link
Contributor

@Shinyaigeek Shinyaigeek commented Aug 30, 2021

Fix: 1121

lingui fails to compile when fallbackLocales: false is specified in lingui configuration and msgStr is missing.
I fixed this issue.

should I add any tests?

@vercel
Copy link

vercel bot commented Aug 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/HPGzhKX4v1e4eoFU8zHQuQbsm17z
✅ Preview: https://js-lingui-git-fork-shinyaigeek-fix-handle-fall-63a9ce-lingui-js.vercel.app

@Shinyaigeek Shinyaigeek force-pushed the fix/handle-fallbackLocales-false branch from dbc0030 to f73a8f0 Compare August 30, 2021 13:25
@Shinyaigeek Shinyaigeek changed the title Fix: handle the case fallbackLocales is false fix: handle the case fallbackLocales is false Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #1123 (f73a8f0) into main (ea00f55) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1123   +/-   ##
=======================================
  Coverage   82.28%   82.28%           
=======================================
  Files          56       56           
  Lines        1677     1677           
  Branches      458      459    +1     
=======================================
  Hits         1380     1380           
  Misses        173      173           
  Partials      124      124           
Impacted Files Coverage Δ
packages/cli/src/api/catalog.ts 81.48% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea00f55...f73a8f0. Read the comment docs.

@semoal semoal changed the title fix: handle the case fallbackLocales is false fix: fallbackLocales to false causing unexpected behaviour Aug 30, 2021
@semoal semoal merged commit 60e3952 into lingui:main Aug 30, 2021
@semoal
Copy link
Contributor

semoal commented Aug 30, 2021

LGTM, thanks for contributing mate. I'll keep merging triage: accepted bugs/features along the week and I'll release a new version next Tuesday.

@semoal semoal mentioned this pull request Sep 2, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'en' of null when specifying "fallbackLocales": false
2 participants