-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for as const
assertions, string literal union types, and quoted object keys
#96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernerx
changed the title
Add support for
feat: add support for Dec 17, 2024
as const
assertions, string literal union types, and quoted object keysas const
assertions, string literal union types, and quoted object keys
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 97.45% 97.70% +0.24%
==========================================
Files 10 10
Lines 433 479 +46
Branches 129 143 +14
==========================================
+ Hits 422 468 +46
Misses 11 11 ☔ View full report in Codecov by Sentry. |
timofei-iatsenko
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three improvements to the
no-unlocalized-strings
rule:as const
assertions since these are typically used to declare fixed values/constants and are not meant for translation.Example:
useTsTypes: true
is enabled, ignores string literals that are part of string literal union types, as these usually represent predefined values rather than user-facing strings.Example:
Example:
Testing
Added test cases for all new functionality:
as const
assertionsuseTsTypes: true
All existing tests continue to pass.