linera-client: generalize over Persist<Target = Wallet> implementation
#2224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twey
force-pushed
the
07-05-Generic_Persist
branch
from
c10081a to
9186db2
Compare
Twey
force-pushed
the
07-05-Generic_Persist
branch
from
9186db2 to
d2430b7
Compare
afck
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We would like to introduce a browser-compatible storage backend for the wallet in order to manage wallets inside the Web wallet. While #2194 introduced the general framework to do so, the implementations in
linera-clientremained specific to the filesystem backend.Proposal
Generalize the implementations of client functionality in
linera-clientto any implementation ofPersist<Target = Wallet>.Test Plan
CI, since
linera-clientwill be tested by the existinglinera-servicetests.Release Plan
Backwards-compatible API change (minor bump).
Links