Fix clippy::use_self in Xilem Core
#747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(GitHub defaulting to draft PR if your last PR was draft is so annoying...) |
DJMcNab
commented
Nov 13, 2024
xilem_core/src/view.rs
Outdated
| @@ -305,7 +305,7 @@ where | |||
| ctx: &mut Context, | |||
| element: Mut<'_, Self::Element>, | |||
| ) { | |||
| if core::mem::take(&mut view_state.dirty) || !Rc::ptr_eq(self, prev) { | |||
| if core::mem::take(&mut view_state.dirty) || !Self::ptr_eq(self, prev) { | |||
There was a problem hiding this comment.
This is probably a downgrade in code quality :(. Do you want me to add an exception?
There was a problem hiding this comment.
Hmm I don't know, I think it's simple enough such that it should be obvious that it's the pointer equality of the Rc/Arc.
Philipp-M
approved these changes
Nov 13, 2024
This matches the style of existing `note: ` fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All fixes except for removing the
expects are results fromcargo fix.