Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use full tracing spans in full-tree passes by default #687

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Don't use full tracing spans in full-tree passes by default #687

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
80805d4
Don't use full tracing spans in passes by default
DJMcNab Oct 18, 2024
d708015
Also add update_tree
DJMcNab Oct 18, 2024
4b19ea3
Add comment on `set_clip_path`
DJMcNab Oct 18, 2024
0f4e8e1
Remove surplus logs
DJMcNab Oct 21, 2024
f7c3f45
Revert extra logging
DJMcNab Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment on set_clip_path
  • Loading branch information
@DJMcNab
DJMcNab committed Oct 21, 2024
commit 4b19ea3dfdad6885b74a625758c3aa8d071f9994
3 changes: 3 additions & 0 deletions masonry/src/contexts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,6 +982,9 @@ impl LayoutCtx<'_> {
/// - It serves as a mask for painting operations of the widget's children (*not* the widget itself).
/// - Pointer events must be inside that path to reach the widget's children.
pub fn set_clip_path(&mut self, path: Rect) {
// This is intentionally not-gated because clip paths are:
// 1) Relatively rare in the tree
// 2) An easy potential source of items not being visible when expected
trace!("set_clip_path {:?}", path);
self.widget_state.clip = Some(path);
// TODO - Updating the clip path may have
Expand Down