Merge `vellottie` #13

simbleau · 2024-03-10T01:31:45Z

This PR will merge in changes from vellottie -
It will also bring velato to a state where it can almost be published.

#14 will bring a followup to continue to prepare for release.

DJMcNab

Lots of small things which need addressing, but overall this works well for me locally

I feel like there is a better way to present the downloads (e.g. in a clickable grid showing them all running at the same time?)

But that can be a follow-on, if you agree that would be good.

.github/workflows/pages-release.yml

.gitignore

src/parser/schema/animated_properties/animated_property.rs

src/import/mod.rs

src/import/util.rs

src/lib.rs

.github/workflows/ci.yml

DJMcNab · 2024-03-11T11:02:20Z

I've also seen that the downloads aren't included in the default runner by default.

I'm not sure the best way to handle that is - we should probably not panic, but yes print the download message?

Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>

.gitignore

Cargo.toml

README.md

examples/assets/LICENSE

examples/scenes/src/download/default_downloads.rs

examples/scenes/src/download.rs

src/import/util.rs

Cargo.toml

Co-authored-by: Kaur Kuut <strom@nevermore.ee>

Cargo.toml

dfrg · 2024-03-14T01:26:06Z

This is rather large and I’m currently otherwise occupied, but at a glance, I don’t see any major blockers and I’ll review this by the of the week.

Thanks @simbleau for taking this on!

Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>

dfrg · 2024-03-16T00:42:43Z

I haven’t forgotten about this. I’ll be taking a look shortly.

dfrg

Thanks Spencer! Overall this looks like a set of solid improvements. I added some notes on things I'd like changed before merging, suggestions for future work and a few random comments.

I'm happy to land this after the requested changes are addressed.

src/import/util.rs

src/lib.rs

src/parser/mod.rs

src/parser/schema/animated_properties/keyframe.rs

src/runtime/model/fixed.rs

dfrg · 2024-03-16T01:48:09Z

src/runtime/model/value.rs

+    /// Easing tangent going into the next keyframe
+    pub in_tangent: Option<EasingHandle>,
+    /// Easing tangent leaving the current keyframe
+    pub out_tangent: Option<EasingHandle>,
+    /// Whether it's a hold frame.


Future work in a follow up: these drastically increase the size of this struct. In cases where tangents are non-existent or sparse, this can waste a lot of space. Skottie stores these in a side table and keeps an index in the actual time struct. We can do the same, packing tangent vec index and the hold bit in a single u32, reducing the size of this to 8 bytes.

Basically, low bit is the hold flag and the high 31 bits store index + 1 where 0 represents no tangents.

Can you link to the Skottie implementation for reference?

Either way, I added this as a task to #14 - Will resolve this one.

I’ll add a comment with the link to that issue.

src/runtime/model/value.rs

src/runtime/render.rs

src/import/converters.rs

dfrg

There’s a huge amount of great work here and I’m very happy to see it land upstream. Thanks!

simbleau added 9 commits March 9, 2024 16:52

fix: licenses

def4ff0

docs: update README

b8c83a0

docs: authors

1375b22

ci: initial CI

ce3c007

refactor: merge vellottie

b9c439f

feat: examples

5df4075

refactor: rename schema Lottie to Animation

1b4322d

build: fix copyright headers

c9a3e1c

fix: wasm compile

86fb77a

simbleau mentioned this pull request Mar 10, 2024

Update git hash #11

Closed

simbleau added 2 commits March 10, 2024 10:19

build: ignore example assets

7142727

ci: remove release workflow

9c0b79b

DJMcNab reviewed Mar 11, 2024

View reviewed changes

This was referenced Mar 11, 2024

Bring in Linebender wide rustfmt settings linebender/vello#513

Merged

Add initial code from Vello. linebender/vello_svg#1

Merged

simbleau and others added 14 commits March 11, 2024 11:27

build: switch demo update to push on main

47a8a0f

build: remove unnecessary items

867ca73

Update .gitignore

6409e34

Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>

fix: authors

15ae080

fix: .gitignore

2682d11

fix: remove trunk

b7b5de7

Update .github/workflows/ci.yml

00e32d8

Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>

fix: authors

7db7178

docs: update badge

ee7089d

docs: update

9ddcee5

docs: update

6166d6f

Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>

build: add tiger license

f646342

Update examples/scenes/Cargo.toml

4ace287

Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>

feat: remove wgpu badge

19c4cc5

docs: update

e5442a8

DJMcNab linked an issue Mar 12, 2024 that may be closed by this pull request

Error parsing Lottie JSON with precomposition #4

Closed

DJMcNab reviewed Mar 12, 2024

View reviewed changes

xStrom reviewed Mar 12, 2024

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

Cargo.toml Outdated Show resolved Hide resolved

simbleau and others added 7 commits March 13, 2024 10:36

Update Cargo.toml

bff269d

Co-authored-by: Kaur Kuut <strom@nevermore.ee>

Update Cargo.toml

98d33b4

Co-authored-by: Kaur Kuut <strom@nevermore.ee>

docs: update

5437119

fix: newline

1c28b1d

build: match text in vello

446d4cf

fix: move tiger to CC-BY dir

07fbe42

feat: google_noto_asset macro

4809b9f

DJMcNab reviewed Mar 13, 2024

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

simbleau requested a review from dfrg March 13, 2024 18:55

simbleau added the release This PR will be followed by a public release. label Mar 13, 2024

Update Cargo.toml

219b546

Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>

simbleau removed the release This PR will be followed by a public release. label Mar 14, 2024

dfrg reviewed Mar 16, 2024

View reviewed changes

src/import/converters.rs Outdated Show resolved Hide resolved

simbleau added 6 commits March 21, 2024 10:00

fix: remove deprecated note

36d9937

build: switch logic to f64

473f118

refactor: switch to f64

ca51bd4

refactor: rename trait to Tween

57dd04b

refactor: finalize merge comments

a892e5c

fix: skew logic

78b78cd

simbleau requested a review from dfrg March 21, 2024 22:33

dfrg approved these changes Mar 22, 2024

View reviewed changes

simbleau merged commit da8abdf into main Mar 22, 2024
9 checks passed

DJMcNab deleted the vellottie-merge branch March 22, 2024 08:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge `vellottie` #13

Merge `vellottie` #13

simbleau commented Mar 10, 2024 •

edited

Loading

DJMcNab left a comment

DJMcNab commented Mar 11, 2024

dfrg commented Mar 14, 2024

dfrg commented Mar 16, 2024

dfrg left a comment

dfrg Mar 16, 2024

simbleau Mar 21, 2024

simbleau Mar 21, 2024

dfrg Mar 22, 2024

dfrg left a comment

Merge vellottie #13

Merge vellottie #13

Conversation

simbleau commented Mar 10, 2024 • edited Loading

DJMcNab left a comment

Choose a reason for hiding this comment

DJMcNab commented Mar 11, 2024

dfrg commented Mar 14, 2024

dfrg commented Mar 16, 2024

dfrg left a comment

Choose a reason for hiding this comment

dfrg Mar 16, 2024

Choose a reason for hiding this comment

simbleau Mar 21, 2024

Choose a reason for hiding this comment

simbleau Mar 21, 2024

Choose a reason for hiding this comment

dfrg Mar 22, 2024

Choose a reason for hiding this comment

dfrg left a comment

Choose a reason for hiding this comment

Merge `vellottie` #13

Merge `vellottie` #13

simbleau commented Mar 10, 2024 •

edited

Loading