Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more information regarding command payload requirements. #1005

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Add more information regarding command payload requirements. #1005

merged 2 commits into from
Jun 1, 2020

Conversation

luleyleo
Copy link
Collaborator

@luleyleo luleyleo commented Jun 1, 2020

This is based on the discussion in #1004 .

It should clarify the payload requirements of Command and Selector.
I've also added a note about generic payloads.

@luleyleo luleyleo added docs concerns documentation S-needs-review waits for review labels Jun 1, 2020
xStrom
xStrom approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems decent.

druid/src/command.rs Outdated Show resolved Hide resolved
@xStrom xStrom removed the S-needs-review waits for review label Jun 1, 2020
@luleyleo luleyleo merged commit 9760cd7 into linebender:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xStrom xStrom xStrom approved these changes

Assignees
No one assigned
Labels
docs concerns documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luleyleo @xStrom