Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X11 shell does not support timers. #934

Closed
luleyleo opened this issue May 15, 2020 · 3 comments
Closed

X11 shell does not support timers. #934

luleyleo opened this issue May 15, 2020 · 3 comments
Labels
help wanted has no one working on it yet missing a feature is missing on a specific platform shell/x11 concerns the X11 backend

Comments

@luleyleo
Copy link
Collaborator

No description provided.

@luleyleo luleyleo added shell/x11 concerns the X11 backend missing a feature is missing on a specific platform help wanted has no one working on it yet labels May 15, 2020
@luleyleo luleyleo changed the title X11 does not support timers. X11 shell does not support timers. May 15, 2020
@xStrom
Copy link
Member

xStrom commented May 15, 2020

I've been thinking of tackling this in the near future. A bunch of examples are broken because of this, so it would be nice to have working.

@xStrom xStrom mentioned this issue May 20, 2020
Closed
@psychon psychon mentioned this issue Jun 19, 2020
Open
16 tasks
@jneem
Copy link
Collaborator

jneem commented Jul 18, 2020

As part of this, the fallback painting code should be changed to use timers. Right now it uses the idle loop, but this isn't ideal: it forces us to either write a bunch of special-case code for painting or else rate-limit the idle loop to avoid painting to often (this is the current state).

psychon added a commit to psychon/druid that referenced this issue Jul 18, 2020
@psychon
Handle timers in the X11 platform's main loop
d948a52 
This makes the following command work correctly (as far as I can see):

  cargo run --example invalidate --no-default-features --features x11

Fixes-half-of: linebender#934
Signed-off-by: Uli Schlachter <psychon@znc.in>
@psychon psychon mentioned this issue Jul 18, 2020
Merged
psychon added a commit to psychon/druid that referenced this issue Jul 19, 2020
@psychon
Handle timers in the X11 platform's main loop
518a451 
This makes the following command work correctly (as far as I can see):

  cargo run --example invalidate --no-default-features --features x11

Fixes-half-of: linebender#934
Signed-off-by: Uli Schlachter <psychon@znc.in>
jneem pushed a commit that referenced this issue Jul 21, 2020
@psychon
Implement timers for the X11 platform (#1096)
cffde32 
Fixes-half-of: #934

Signed-off-by: Uli Schlachter <psychon@znc.in>
@luleyleo
Copy link
Collaborator Author

luleyleo commented Sep 6, 2020

I've opened #1186 as a separate issue for the fallback painting, because this issue has basically been resolved.

@luleyleo luleyleo closed this as completed Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted has no one working on it yet missing a feature is missing on a specific platform shell/x11 concerns the X11 backend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xStrom @jneem @luleyleo