-
Notifications
You must be signed in to change notification settings - Fork 568
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: linebender/druid
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4bdc3fe
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: linebender/druid
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2996ae2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 15 commits
- 75 files changed
- 5 contributors
Commits on Apr 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0051dca - Browse repository at this point
Copy the full SHA 0051dcaView commit details
Commits on Apr 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 6cbffc2 - Browse repository at this point
Copy the full SHA 6cbffc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for def0fb9 - Browse repository at this point
Copy the full SHA def0fb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a21f9a - Browse repository at this point
Copy the full SHA 8a21f9aView commit details
Commits on Apr 15, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 2e1c601 - Browse repository at this point
Copy the full SHA 2e1c601View commit details -
Add docs for Painter & Controller
This is the first part of the major section going over custom widgets and the general widget model.
Configuration menu - View commit details
-
Copy full SHA for 7fccd1f - Browse repository at this point
Copy the full SHA 7fccd1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 81d3abc - Browse repository at this point
Copy the full SHA 81d3abcView commit details -
Apply suggestions from code review
Co-Authored-By: Leopold Luley <git@leopoldluley.de>
Configuration menu - View commit details
-
Copy full SHA for 185941d - Browse repository at this point
Copy the full SHA 185941dView commit details -
Merge pull request #841 from xStrom/true-hot
Keep hot state consistent with mouse position.
Configuration menu - View commit details
-
Copy full SHA for ee55405 - Browse repository at this point
Copy the full SHA ee55405View commit details -
* Add wasm backend + fix std::time dep A basic wasm backend is added as a continuation of #30. Since std::time isn't available on wasm, an additional dependency is added to abstract std::time::Instant to work with wasm. * Disable simple logger on wasm This commit ensures that all examples run with minimal changes. More specifically we don't need to remove the .use_simple_logger() call on all Apps. * Fix resizing in wasm backends The resize callback should be registered to the window, since resizing the window doesn't call the resize callback for canvases even if those do get resized. * Added scrolling support + fixed hidpi handling The scroll example now works as expected on hi and low dpi screens. * Use explicit lifetime in StrOrChar This makes passing it easier to pass owned strings when creating a new KeyEvent, which is necessary when interfacing with WASM. * Prevent the browser from going back on backspace This should be the default behavior to make text widgets usable. At a later iteration it may be better to only disable the browser from going back when a widget is selected that is expecting keyboard input where backspace is intended for something else. I expect this functionality would require some way of accessing the web_sys event from within a druid callback. * Fix key text + require console_log + adjust style This commit addresses comments in the code review: Key text: - web_sys returns the name of each pressed key from which we can generate a viable printable string. This mechanism is revised to include all non-printable keys as listed in MDN. - notably, the tab character and numpad characters have gained printable text in this commit. console_log: - console_log is not required in wasm builds. - integrated console_log with the use_simple_logger api. `console_log` is initialized with log level `trace` as is done in simple logger by default. Style: - non std use statements are now before third party use statements. - key_to_text function signature refactor - specify the log module when calling log::{warn, error} explicitly. * Fix up console_log dependency Moved console_log dependency from druid-shell to druid, since this is where it is initialized. This fixes the wasm build. * Fix the build script for wasm examples This addresses the CI failures caused by the weird build of the wasm examples. To elaborate: In order to include each of the examples in the wasm example, a symlink to the examples directory is created in build.rs along with the corresponding examples.rs module which declares examples known to work with wasm. To satisfy CI, the examples.rs committed to the repo must be empty since rustfmt does not call "build.rs". * Add .gitignore to wasm examples + fix clippy bugs The included .gitignore ignores the generated examples module. The examples.rs should remain committed, but it need not be ever changed. * Fix x11 keycodes StrOrChar conversion The newly introduced lifetime parameter must be specified exmplicitly. * Add --no-run to `cargo test` for wasm targets wasm targets cannot be run in the normal way. * Do not build the unit test module for wasm32 The tests cannot be run in the normal way anyways. Leaving this for a future PR to flush out. * Install necessary deps in wasm CI for macos/ubuntu * Add warnings for unimplemented file ops in web backend This commit exposes the error of the missing implementation for file dialogs in the web backend using log::warn. This is a temporary solution until the `open_file_sync` and `save_as_sync` functions propagate the error downstream using Result instead of Option. * Rework the generated examples in the wasm example This commit attempts a different approach at including the automatically generated examples from the parent directory. This method satisfies both rustfmt and cargo test as before, but it also doesn't modify any files in the source tree, keeping the diff clean after a build. * Rename switch example js entry point for wasm build This commit fixes the generated html file for the switch example to load "switch_demo" instead of "switch" for the switch example. The word switch conflicts with JavaScript's switch statement, which is the reason for this awkwardness. Co-authored-by: Leopold Luley <git@leopoldluley.de>
Configuration menu - View commit details
-
Copy full SHA for 37b9646 - Browse repository at this point
Copy the full SHA 37b9646View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cca825 - Browse repository at this point
Copy the full SHA 7cca825View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12e5f54 - Browse repository at this point
Copy the full SHA 12e5f54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 900369d - Browse repository at this point
Copy the full SHA 900369dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9d133e - Browse repository at this point
Copy the full SHA d9d133eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2996ae2 - Browse repository at this point
Copy the full SHA 2996ae2View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 4bdc3fe...2996ae2