Parley work #130

RobertBrewitz · 2025-03-19T13:08:44Z

PR to integrate parley and font variants.

PR should close #101 .

Using this zulip thread for more direct commuication: https://xi.zulipchat.com/#narrow/channel/205635-parley/topic/.E2.9C.94.20Parley.2C.20layout.20context.2C.20bevy.20and.20multiple.20cores/with/507732907

adds default font plugin as the logic has to be a bit more intricate

RobertBrewitz · 2025-03-21T09:15:47Z

PR is a bit on hold, currently investigating performance issues with font rendering.

RobertBrewitz · 2025-03-22T14:25:44Z

Ok, resuming work on this and hope that the future hybrid renderer works better with font rendering.

CHANGELOG.md

simbleau · 2025-03-25T13:15:22Z

I'm unable to run the text example as is, I get a panic.

Panic originates from here: https://github.com/dfrg/swash/blob/af00b06d9045af8c853eabf3b9eb8b6aed8610c1/src/shape/at.rs#L572

2025-03-25T13:16:33.900863Z  INFO bevy_render::renderer: AdapterInfo { name: "Apple M1 Max", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }
Initialising in parallel using 8 threads
2025-03-25T13:16:34.325168Z  INFO bevy_winit::system: Creating new window "App" (0v1#4294967296)
2025-03-25 09:16:34.531 text[11025:13778357] +[IMKClient subclass]: chose IMKClient_Modern
2025-03-25 09:16:34.531 text[11025:13778357] +[IMKInputSession subclass]: chose IMKInputSession_Modern

thread 'Compute Task Pool (2)' panicked at /Users/simbleau/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/swash-0.2.1/src/shape/at.rs:572:25:
attempt to subtract with overflow
stack backtrace:
   0: rust_begin_unwind
             at /rustc/4d91de4e48198da2e33413efdcd9cd2cc0c46688/library/std/src/panicking.rs:692:5
   1: core::panicking::panic_fmt
             at /rustc/4d91de4e48198da2e33413efdcd9cd2cc0c46688/library/core/src/panicking.rs:75:14
   2: core::panicking::panic_const::panic_const_sub_overflow
             at /rustc/4d91de4e48198da2e33413efdcd9cd2cc0c46688/library/core/src/panicking.rs:178:21
   3: swash::shape::at::CoverageBuilder::finish
             at /Users/simbleau/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/swash-0.2.1/src/shape/at.rs:572:25
   4: swash::shape::at::FeatureStoreBuilder::build_stage
             at /Users/simbleau/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/swash-0.2.1/src/shape/at.rs:482:39
   5: swash::shape::at::FeatureStoreBuilder::build
             at /Users/simbleau/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/swash-0.2.1/src/shape/at.rs:389:13
   6: swash::shape::engine::Engine::collect_features
             at /Users/simbleau/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/swash-0.2.1/src/shape/engine.rs:109:9
   7: swash::shape::ShaperBuilder::build
             at /Users/simbleau/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/swash-0.2.1/src/shape/mod.rs:539:21
   8: swash::shape::partition::shape_clusters
             at /Users/simbleau/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/swash-0.2.1/src/shape/partition.rs:219:22
   9: swash::shape::partition::shape
             at /Users/simbleau/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/swash-0.2.1/src/shape/partition.rs:186:15
  10: parley::shape::shape_text
             at /Users/simbleau/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/parley-0.3.0/src/shape.rs:110:13
  11: parley::builder::build_into_layout
             at /Users/simbleau/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/parley-0.3.0/src/builder.rs:172:9
  12: parley::builder::RangedBuilder<B>::build_into
             at /Users/simbleau/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/parley-0.3.0/src/builder.rs:55:9
  13: parley::builder::RangedBuilder<B>::build
             at /Users/simbleau/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/parley-0.3.0/src/builder.rs:60:9
  14: bevy_vello::text::font::VelloFont::render::{{closure}}::{{closure}}
             at ./src/text/font.rs:99:34
  15: std::thread::local::LocalKey<core::cell::RefCell<T>>::with_borrow_mut::{{closure}}
             at /Users/simbleau/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/thread/local.rs:529:26
  16: std::thread::local::LocalKey<T>::try_with
             at /Users/simbleau/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/thread/local.rs:308:12
  17: std::thread::local::LocalKey<T>::with
             at /Users/simbleau/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/thread/local.rs:272:9
  18: std::thread::local::LocalKey<core::cell::RefCell<T>>::with_borrow_mut
             at /Users/simbleau/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/thread/local.rs:529:14
  19: bevy_vello::text::font::VelloFont::render::{{closure}}
             at ./src/text/font.rs:88:13
  20: std::thread::local::LocalKey<core::cell::RefCell<T>>::with_borrow_mut::{{closure}}
             at /Users/simbleau/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/thread/local.rs:529:26
  21: std::thread::local::LocalKey<T>::try_with
             at /Users/simbleau/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/thread/local.rs:308:12
  22: std::thread::local::LocalKey<T>::with
             at /Users/simbleau/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/thread/local.rs:272:9
  23: std::thread::local::LocalKey<core::cell::RefCell<T>>::with_borrow_mut
             at /Users/simbleau/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/thread/local.rs:529:14
  24: bevy_vello::text::font::VelloFont::render
             at ./src/text/font.rs:81:9
  25: bevy_vello::render::systems::render_frame
             at ./src/render/systems.rs:212:21
  26: core::ops::function::FnMut::call_mut
             at /Users/simbleau/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:166:5
  27: core::ops::function::impls::<impl core::ops::function::FnMut<A> for &mut F>::call_mut
             at /Users/simbleau/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:294:13
  28: <Func as bevy_ecs::system::function_system::SystemParamFunction<fn(F0,F1,F2,F3,F4,F5,F6,F7,F8) .> Out>>::run::call_inner
             at /Users/simbleau/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bevy_ecs-0.15.3/src/system/function_system.rs:1002:21
  29: <Func as bevy_ecs::system::function_system::SystemParamFunction<fn(F0,F1,F2,F3,F4,F5,F6,F7,F8) .> Out>>::run
             at /Users/simbleau/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bevy_ecs-0.15.3/src/system/function_system.rs:1005:17
  30: <bevy_ecs::system::function_system::FunctionSystem<Marker,F> as bevy_ecs::system::system::System>::run_unsafe
             at /Users/simbleau/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bevy_ecs-0.15.3/src/system/function_system.rs:800:19
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Encountered a panic in system `bevy_vello::render::systems::render_frame`!

simbleau · 2025-03-25T13:34:42Z

If I run it in release mode, everything works fine. Not sure if this is an issue for swash or you?

simbleau

As soon as this doesn't cause a panic when I run it in debug mode I can approve this. It looks great!

src/text/default_font_plugin.rs

RobertBrewitz · 2025-03-25T14:28:17Z

If I run it in release mode, everything works fine. Not sure if this is an issue for swash or you?

Happens here also, peculiar, I'll look into it.

RobertBrewitz · 2025-03-25T16:01:39Z

If I run it in release mode, everything works fine. Not sure if this is an issue for swash or you?

Something with swash and bevy's default font it seems, asking around a bit what needs to be done to solve it.

RobertBrewitz · 2025-03-26T14:54:23Z

Awating the panic issue to be solved in swash, here: dfrg/swash#90

simbleau · 2025-03-29T13:53:53Z

Awaiting release, patch put into swash.

simbleau

Approved as soon as the cargo update is done

RobertBrewitz force-pushed the robertbrewitz/parley branch 5 times, most recently from 7f4226c to 689c04f Compare March 19, 2025 21:07

removes skrifa crate and adds parley crate

a5463f4

RobertBrewitz force-pushed the robertbrewitz/parley branch 2 times, most recently from abe10a4 to b5b0c69 Compare March 20, 2025 07:55

RobertBrewitz added 4 commits March 20, 2025 08:59

adds parley font and layout contexts with thread local

c3ea025

adds logic to update font contexts in the main and compute threads

2365503

updates font rendering to use parley instead of skrifa

1842e3b

adds default font plugin as the logic has to be a bit more intricate

fmt

9ac5ec5

RobertBrewitz force-pushed the robertbrewitz/parley branch from 91bf3e0 to 9ac5ec5 Compare March 20, 2025 08:00

RobertBrewitz added 2 commits March 20, 2025 13:54

updates example with animated variable font weight

ccbdf23

adds effort to ensure all threads registers font

2618301

RobertBrewitz force-pushed the robertbrewitz/parley branch from 65300b6 to 2618301 Compare March 20, 2025 12:55

RobertBrewitz added 4 commits March 20, 2025 14:14

spelling fix

93bb972

changes font context to shared and multi-threaded mode

ba2a961

fmt

9e26a4a

removes unnecessary mut

eaeaa3a

fixes wasm build with parley

a547e1d

RobertBrewitz added 3 commits March 22, 2025 16:44

move out calculation from loop

1f03e7f

fixes anchoring with parley and adds axes variables

fa76eac

updates example to be able to toggle all axes variables

1cc4688

RobertBrewitz force-pushed the robertbrewitz/parley branch from d772388 to 1cc4688 Compare March 22, 2025 21:35

RobertBrewitz added 3 commits March 22, 2025 22:44

use Cow::Owned instead of Cow::Borrowed

b56e849

fmt

c847fd2

updates cargo lock

24524a4

adds word & letter spacing

f558659

This was referenced Mar 25, 2025

Enhancement: Strike through and underline #133

Open

Enhancement: FontVariant and FontStyle applied to ranges #134

Open

simbleau reviewed Mar 25, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

8ad2cc8

simbleau reviewed Mar 25, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

be17ddc

simbleau requested changes Mar 25, 2025

View reviewed changes

simbleau reviewed Mar 25, 2025

View reviewed changes

src/text/default_font_plugin.rs Outdated Show resolved Hide resolved

removes default plugin and hardcode bevy's default font family name

3dfc4db

RobertBrewitz force-pushed the robertbrewitz/parley branch from bc4dfab to 3dfc4db Compare March 25, 2025 18:08

RobertBrewitz added 3 commits March 25, 2025 19:09

cleanup comment

f5deb69

remove changelog entry about default font plugin that is removed

dedfdb1

fix loading default font into parley font context

96e8251

RobertBrewitz force-pushed the robertbrewitz/parley branch from f1ae225 to 96e8251 Compare March 25, 2025 18:53

RobertBrewitz added 2 commits March 25, 2025 19:59

revert color change of text example gizmos

6d52264

fmt

1f831be

simbleau approved these changes Apr 2, 2025

View reviewed changes

cargo update

683fdc3

RobertBrewitz enabled auto-merge April 2, 2025 06:26

RobertBrewitz added this pull request to the merge queue Apr 2, 2025

Merged via the queue into linebender:main with commit b0ab058 Apr 2, 2025
4 checks passed

RobertBrewitz deleted the robertbrewitz/parley branch April 2, 2025 18:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Parley work #130

Parley work #130

Uh oh!

RobertBrewitz commented Mar 19, 2025 •

edited

Loading

Uh oh!

RobertBrewitz commented Mar 21, 2025

Uh oh!

RobertBrewitz commented Mar 22, 2025

Uh oh!

Uh oh!

Uh oh!

simbleau commented Mar 25, 2025 •

edited

Loading

Uh oh!

simbleau commented Mar 25, 2025

Uh oh!

simbleau left a comment

Uh oh!

Uh oh!

RobertBrewitz commented Mar 25, 2025

Uh oh!

RobertBrewitz commented Mar 25, 2025

Uh oh!

RobertBrewitz commented Mar 26, 2025

Uh oh!

simbleau commented Mar 29, 2025

Uh oh!

simbleau left a comment

Uh oh!

Uh oh!

Uh oh!

Parley work #130

Parley work #130

Uh oh!

Conversation

RobertBrewitz commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RobertBrewitz commented Mar 21, 2025

Uh oh!

RobertBrewitz commented Mar 22, 2025

Uh oh!

Uh oh!

Uh oh!

simbleau commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simbleau commented Mar 25, 2025

Uh oh!

simbleau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RobertBrewitz commented Mar 25, 2025

Uh oh!

RobertBrewitz commented Mar 25, 2025

Uh oh!

RobertBrewitz commented Mar 26, 2025

Uh oh!

simbleau commented Mar 29, 2025

Uh oh!

simbleau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

RobertBrewitz commented Mar 19, 2025 •

edited

Loading

simbleau commented Mar 25, 2025 •

edited

Loading