Ignore url params (query string)

[carloschneider]

I've a scenario where I need generate dynamic url params, like:

?person[0][name]=John+Doe&person[1][name]=Hello+World

When I set the mockData I need mock the parameters too. That way I've got an error when the mock is different from the url request: net::ERR_NAME_NOT_RESOLVED.

A solution would be to create an option to disable the query string check.

[nutboltu]

@carloschneider this is a special case, where we have to ignore the query parameters. In this scenario, it would be good if we used an asterisk(*) in the URL path to ignore them. Like below

/todos?*

In the package, we are using pathtoregexp package to match the paths. I would recommend trying this approach to resolve this issue.

As this is a special case, introducing a new field Ignore params will make confusion to others. Moreover, this is not a generalized API for this addon.

Considering the overall perception, I am going to revert the PR. Let's discuss further if the asterisk(*) option would fit your requirement.

[carloschneider]

@nutboltu Using * doesn't work https://runkit.com/embed/uqis3n6q1qt6.

The code just tests path with path-to-regexp. The query string is tested separated.

https://github.com/nutboltu/storybook-addon-mock/blob/8705e8ba31eabcf5117e918c509a79ea345f1582/src/utils/faker.js#L86-L89

[nutboltu]

The idea is to replace with match function with the exec function which supports the *. ATM, I haven't managed time to look into this implementation during this holiday. Hope to start working on this feature early next year.

But any PR will be welcomed 💯

[carloschneider]

@nutboltu right.

What if we remove that params validation line?

https://github.com/nutboltu/storybook-addon-mock/blob/aa49c2245d57f9d305a421bfa64c2b9c0e93a235/src/utils/faker.js#L88

[saulrobe]

Is there any progress on this?

[tenorok]

I suggest (#115) to give comparing query parameters to path-to-regexp package like the path. There we have one disadvantage that this package not handle different order of parameters, but we always can pass regexp { url: '/path?(.*)' } and write our custom response function.

[adriankott]

First of all thank you for the great package it's really useful for us.
Can we have an update on this ? we would like to mock dynamic urls and since even the order of query params is fixed we cannot do this at the moment.
Thanks.

[nutboltu]

@tenorok @adriankott I am currently wrapping things up in launching version 3 of the addon. I have seen @tenorok already raised a PR. I will include the changes in version 3. The overall ETA would be 2-3 weeks. I would really appreciate your patience.

[solteax]

Just a suggestion - would be useful with optional property "parameters" with the value of obj/array which will not care about the sequence.
{ url: '/someUrl', method: 'GET', parameters: { param1:'val1', param2: 'val2' } || [ 'param1=val1', 'param2=val2' ] }