Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make it able to build with 2020.3.48f1 (b805b124c6b7) #54

Merged
merged 6 commits into from
Aug 24, 2023

Conversation

tsairene
Copy link
Contributor

Verify on: 2020.3.48f1 (b805b124c6b7) & 2022.3.4f1

@onevcat
Copy link
Member

onevcat commented Jul 24, 2023

Ummm. I tries these changes but I am still getting these errors in both 2020.3.0 and 2022.3.4:

2020.3.0

  java.lang.RuntimeException: Duplicate class androidx.lifecycle.ViewModelLazy found in modules jetified-lifecycle-viewmodel-ktx-2.2.0-runtime.jar (androidx.lifecycle:lifecycle-viewmodel-ktx:2.2.0) and lifecycle-viewmodel-2.4.0-runtime.jar (androidx.lifecycle:lifecycle-viewmodel:2.4.0)

...and more others. Seems the jetified classes are conflicting with those are not.

(Did not yet try on 2020.3.48, since my available disk space is not enough to install another Unity now. I will find a chance later)

2022.3.4

> Failed to apply plugin 'com.android.internal.application'.
   > Cannot parse project property android.enableR8='' of type 'class java.lang.String' as boolean. Expected 'true' or 'false'.

Since all the settings from LINE SDK under the Android Plugins folder will be merged into the final product, I would suggest to keep it as easy as possible. If there is no special reason, I don't think changing the R8 setting is a good idea.

@onevcat
Copy link
Member

onevcat commented Jul 24, 2023

I believe the most of the issues come from an incompatible version with the dependencies from Unity versions.

I will try to see if I can make it work if we upgrade the minimal version to Unity 2020.3.15:

截屏2023-07-24 14 34 06

Copy link
Member

@plateaukao plateaukao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onevcat onevcat mentioned this pull request Jul 24, 2023
@onevcat
Copy link
Member

onevcat commented Aug 21, 2023

I am closing this since it fails to compile and the related changes should be already covered by #55

@onevcat onevcat closed this Aug 21, 2023
@onevcat onevcat reopened this Aug 24, 2023
@onevcat onevcat merged commit ff5d501 into master Aug 24, 2023
@onevcat onevcat deleted the rene/fixFor2020 branch August 24, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants