Skip to content

Conversation

@ta7uw
Copy link
Member

@ta7uw ta7uw commented Mar 28, 2020

Resolves #306
Related PR #360

Some fields to represent URL remains in using String type.
Replaces String with URI.

@codecov-io
Copy link

codecov-io commented Mar 28, 2020

Codecov Report

Merging #491 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #491      +/-   ##
============================================
- Coverage     71.78%   71.59%   -0.19%     
- Complexity      319      327       +8     
============================================
  Files           180      182       +2     
  Lines          1786     1841      +55     
  Branches         66       71       +5     
============================================
+ Hits           1282     1318      +36     
- Misses          462      478      +16     
- Partials         42       45       +3
Impacted Files Coverage Δ Complexity Δ
...inecorp/bot/model/message/flex/component/Icon.java 48.38% <ø> (ø) 1 <0> (ø) ⬇️
.../request/CreateClickBasedAudienceGroupRequest.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...om/linecorp/bot/client/LineOAuthClientBuilder.java 83.33% <0%> (-2.04%) 7% <0%> (ø)
...m/linecorp/bot/client/LineMessagingClientImpl.java 82.14% <0%> (-0.84%) 37% <0%> (-9%)
.../model/message/imagemap/MessageImagemapAction.java 100% <0%> (ø) 1% <0%> (ø) ⬇️
.../bot/model/message/imagemap/URIImagemapAction.java 100% <0%> (ø) 1% <0%> (ø) ⬇️
...a/com/linecorp/bot/client/LineMessagingClient.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
...corp/bot/servlet/LineBotCallbackRequestParser.java 91.66% <0%> (ø) 4% <0%> (ø) ⬇️
...corp/bot/spring/boot/LineBotAutoConfiguration.java 100% <0%> (ø) 6% <0%> (+1%) ⬆️
...om/linecorp/bot/client/LineSignatureValidator.java
... and 4 more

@ta7uw ta7uw changed the title Change type of URL field to URI #306 Change type of URL field to URI Mar 28, 2020
@kazuki-ma
Copy link
Contributor

Thank you. Changes looks good.
And I think we can change it with release note (without deprecation step).

@kazuki-ma kazuki-ma merged commit 6b2f13f into line:master Mar 28, 2020
@kazuki-ma
Copy link
Contributor

p.s. We are planning next major release. This change may be skips in next minor and released as a part of next major.

@ta7uw ta7uw deleted the issue-306 branch March 28, 2020 11:41
@kazuki-ma kazuki-ma added this to the 3.5.0 milestone Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change type of URL field to URI

3 participants