Model VideoMessageContent not fit to the document

[alex-lx]

Model in the SDK:

line-bot-sdk-java/line-bot-model/src/main/java/com/linecorp/bot/model/event/message/VideoMessageContent.java

Lines 32 to 40 in 407d85e

	public class VideoMessageContent implements MessageContent {
	@JsonPOJOBuilder(withPrefix = "")
	public static class VideoMessageContentBuilder {
	// Providing builder instead of public constructor. Class body is filled by lombok.
	}
	String id;
	URI url;
	ContentProvider contentProvider;

Model in the document:
https://developers.line.biz/en/reference/messaging-api/#wh-video

  {
    "id": "325708",
    "type": "video",
    "duration": 60000,
    "contentProvider": {
      "type": "external",
      "originalContentUrl": "https://example.com/original.mp4",
      "previewImageUrl": "https://example.com/preview.jpg"
    }
  }

In SDK, the model has no duration field and has one extra url field.

[tokuhirom]

The issue was introduced by this commit. 51fb038

[alex-lx]

Hi, @tokuhirom.

Would you mind to change the duration field type to Integer which is the duration type in AudioMessageContent class.

And, something not so related, using a number to represent duration is not clear which unit was used, think to change the field name to durationMillis or use java.time.Duration type would be better.

[tokuhirom]

ah. good catch. I changed the type to Integer.

[tokuhirom]

Duration support is a good idea, but there's nothing method like this in the sdk.... now.
maybe we can change the type at next major release :P

[alex-lx]

Got it, feel free to close this issue when resolved.