Support Arithmetic function EXP #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbl428
requested review from
pickmoment,
huisam,
cj848 and
shouwn
as code owners
cj848
reviewed
Feb 1, 2024
| @@ -287,6 +288,7 @@ private class DefaultModule : JpqlRenderModule { | |||
| JpqlEqualAnySerializer(), | |||
| JpqlEqualSerializer(), | |||
| JpqlExistsSerializer(), | |||
| JpqlExpSerializer(), | |||
There was a problem hiding this comment.
It seems to me that this code should be placed under JpqlExpressionSerializer(). If you look at it in alphabetical order
There was a problem hiding this comment.
Ah, I have followed import line order :)
shouwn
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Commit Convention Rule
commit typeplease describe it on the Pull RequestResult
expis added.Closes