Add source_cluster tag when emitting DLQ size (uber#4782)

lindleywhite · Mar 29, 2022 · 33edece · 33edece
1 parent ba4a5d9
commit 33edece
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/common/metrics/tags.go b/common/metrics/tags.go
@@ -33,6 +33,7 @@ const (
 
 	instance               = "instance"
 	domain                 = "domain"
+	sourceCluster          = "source_cluster"
 	targetCluster          = "target_cluster"
 	activeCluster          = "active_cluster"
 	taskList               = "tasklist"
@@ -92,6 +93,11 @@ func InstanceTag(value string) Tag {
 	return simpleMetric{key: instance, value: value}
 }
 
+// SourceClusterTag returns a new source cluster tag.
+func SourceClusterTag(value string) Tag {
+	return metricWithUnknown(sourceCluster, value)
+}
+
 // TargetClusterTag returns a new target cluster tag.
 func TargetClusterTag(value string) Tag {
 	return metricWithUnknown(targetCluster, value)

diff --git a/service/history/replication/task_processor.go b/service/history/replication/task_processor.go
@@ -629,6 +629,7 @@ func (p *taskProcessorImpl) emitDLQSizeMetricsLoop() {
 			} else {
 				p.metricsClient.Scope(
 					metrics.ReplicationDLQStatsScope,
+					metrics.SourceClusterTag(p.sourceCluster),
 					metrics.InstanceTag(strconv.Itoa(p.shard.GetShardID())),
 				).UpdateGauge(metrics.ReplicationDLQSize, float64(resp.Size))
 			}