Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pharmacode validation checks only the range of
parseInt(data), so inputs such as3.5,3junk, and3e4are accepted and encode the value 3 while displaying different text. Pharmacode input is an integer, as described by the project documentation and the Laetus guide linked in the encoder.Reject non-digit input before the existing range check. Digit-only leading-zero values remain accepted, as do the existing 3 and 131070 boundaries. Regression cases cover decimals, numeric suffixes, scientific notation and whitespace, including final line terminators.
The new regression fails on the original code. Validation: the full
npm testsuite passes with 110 tests on Node 18 and the repository's canvas dependency. The changed source passes ESLint with the repository config's obsoletepredefkey normalized outside the patch. The existinggulp lintcommand is blocked by that invalid config, and normalized whole-source lint reports unrelated existing errors.git diff --checkpasses. No generated bin/dist or dependency changes are included.