Need to create the torch Generator on the correct device.#924
Merged
Conversation
Collaborator
Author
|
Given that this addresses the issue, we should draft a new release after this merges. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Hyrax’s Ignite distributed dataloader helper to construct the torch.Generator on the Ignite-selected device (intended to align RNG behavior with non-CPU backends like MPS on macOS).
Changes:
- Create
torch.Generatorwithdevice=idist.device()insidedist_data_loader.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #924 +/- ##
=======================================
Coverage 67.72% 67.72%
=======================================
Files 70 70
Lines 6805 6805
=======================================
Hits 4609 4609
Misses 2196 2196 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Agent-Logs-Url: https://github.com/lincc-frameworks/hyrax/sessions/4f76dfac-175d-46f2-85e5-a3501f55afef Co-authored-by: drewoldag <47493171+drewoldag@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The torch generator will, by default be created on CPU, but it needs to be in the same place as the rest of the data. On Mac, that means MPS by default.