Rebase after squash #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses: #1832 (comment)
Addresses: #1832 (diff)
Available when 'grpcio' and related packages are importable. Enable via 'GCLOUD_ENABLE_GAX' environment variable. Disabled by default due to #1873.
Pass the 'PROTOC_CMD' and 'GRPC_PLUGIN' values through from make's environment to the scripts used to pick apart GRPC-specific code.
Put them in a separate '_generated_v2' subdir, to ease migration. Attempt to factor generation process for clarity (toward #1482).
It was never actually implemented on the back-end in V1, and has been dropped altogether in V2.
Generate code for Bigtable v2 protobufs
Processes the 'ReadRowsResponse.CellChunk' state machine. Add tests based on JSON acceptance tests: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/master/bigtable-client-core/src/test/resources/com/google/cloud/bigtable/grpc/scanner/v2/read-rows-acceptance-test.json.
Drop 'Table.rename'.
Closes #1869. Works around googleapis/gax-python#113.
Indicate their V1 source in their names. Prepratory to converting to V2 equivalents.
…logic Add 'ReadRowsResponseV2' wrapper
…ints Alias Bigtable V1 imports / factories / entry point constants.
…g_for_publish Disable GAX bundling for 'Topic.publish'.
Note that {Create,Update,Delete}ColumnFamily messages all collapse to
ModifyColumnFamilies.
Update bigtable.column_family to use V2 protos
Adjust anchor scroll in docs to show actual line.
Fix GAX logging system tests
Update references from Cloud Logging to Stackdriver Logging
- Put '_testing' on PYTHONPATH only for Py3k (debug grpico-on-Py3k issues later). - Use 'setup.py develop' rather than 'setup.py build' to get dependencies installed. - Run 'pip list' afterwards to show what got installed. Toward #1863.
…appveyor Attempt to un-break Appveyor:
…pubsub-bundling Revert "Re-enable bundling (for consideration)"
Update disabled messages so new pylint passes
Change error for generating signed URL.
Install GAX-related wrappers via pip to work around #1972.
…e-for-sure Appveyor: this-time-for-sure-rocky
Make dataset snippets testable
…ngs-breakage Disable pylint 1.6 warnings / work around breakage
…ndows Attempt to fix windows path crash
Update DNS resource_record_set()
Add quotes to CSV reference
Make table snippets testable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.