[DON"T REVIEW]TW-459: reduce frames in chat list #466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangdat
reviewed
Aug 16, 2023
| @@ -79,6 +78,8 @@ class ChatListController extends State<ChatList> | |||
|
|
|||
| String? activeSpaceId; | |||
|
|
|||
| final chatListIndexes = <String, int>{}; | |||
There was a problem hiding this comment.
It's a method for optimizing the number of rebuild of the chat list when the chat list is reordered
|
Your PR is very very hard for me. Plss help me easy for understand more about your PR |
describe your problem |
ADR + video demo |
nqhhdev
reviewed
Aug 16, 2023
| @@ -31,224 +28,200 @@ class ChatListViewBody extends StatelessWidget { | |||
| final userSearchResult = controller.userSearchResult; | |||
| final client = Matrix.of(context).client; | |||
|
|
|||
| return PageTransitionSwitcher( | |||
There was a problem hiding this comment.
Why did you delete it? It's better about performance right?
There was a problem hiding this comment.
Why it's better for performance ?. I think currently we don't use the animation, so just remove it for now
sherlockvn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profile mode: run on iphone X
Before refactoring:
RPReplay_Final1692177389.mp4
After refactoring:
RPReplay_Final1692177940.mp4
Conclusion:
The average and max ms/frame before refactoring is lower than after refactoring, so the performance before is better