Skip to content

TF-2313 Open Twake Chat app after invitation when app was login with other account #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dab246
Copy link
Member

@dab246 dab246 commented May 15, 2025

Ticket

#2313

Resolved

  • App is not logged in:
demo-auto-app-not-logged.webm
  • App is logged in with same Home Server and exist one client

  • Cancel switch to account:

same-homeser-and-other-account-cancel.webm
  • Accept switch to account:
accept-same-homeserver-other-account.webm
  • App is logged in with same Home Server and exist multiple clients
demo-multiple.webm
  • App is logged in with different Home Server
different-homeserver.webm
  • App is terminated
app-terminate-different-homeserver.webm

Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/2335

@dab246 dab246 force-pushed the bugfix/tw-2313-open-twake-chat-app-after-invitation-when-app-was-login-with-other-account branch from 0016297 to 6e08ed0 Compare May 16, 2025 10:14
@hoangdat
Copy link
Member

  • app be logout after logout from web

Reproduce

  1. login signup in browser
  2. click in app list in signup in browser
  3. open app
  4. login in app
  5. comeback to signup page in browser
  6. logout in browser
  7. open app again
  8. app be logout

}

Future<void> _logoutActionsOnMobile({required MatrixState matrix}) async {
await tryLogoutSso(matrix: matrix);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was removed on the latest change. Please remove it too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

String? redirectUrl,
}) {
if (redirectUrl != null) {
final redirectUrlEncode = base64Url.encode(utf8.encode(redirectUrl));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it also was removed.

String? _getLogoutUrl(BuildContext context) {
. Please remove it too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@dab246
Copy link
Member Author

dab246 commented May 19, 2025

  • app be logout after logout from web

Reproduce

  1. login signup in browser
  2. click in app list in signup in browser
  3. open app
  4. login in app
  5. comeback to signup page in browser
  6. logout in browser
  7. open app again
  8. app be logout

It also happens in case when we add another account on the app:

Reproduce

  1. login account use homeserver of staging on app
  2. After login success on app
  3. open browser and enter sigup page
  4. Auto login account on browser
  5. Logout account in browser
  6. open app again
  7. app be logout
  • Console log on app:
[Matrix] 2025-05-19 12:31:25.593966: The user has been logged out!
[Matrix] 2025-05-19 12:31:25.320858: M_UNKNOWN_TOKEN: Invalid access token passed.

@hoangdat
Copy link
Member

  • app be logout after logout from web

Reproduce

  1. login signup in browser
  2. click in app list in signup in browser
  3. open app
  4. login in app
  5. comeback to signup page in browser
  6. logout in browser
  7. open app again
  8. app be logout

Hi @rezk2ll , please check the video

ScreenRecording_05-19-2025.15-29-45_1.MP4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants