TW-2150 fix confirm button not displaying when changing group avatar #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhaledNjim
requested review from
hoangdat,
dab246,
nqhhdev and
tddang-linagora
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/2153 |
hoangdat
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
[BUG] Could not change avatar of group chat #2150
side effect from Tw 2046 group name validation #2119
Root cause
The initial value for
isValidGroupNameNotifieris set to false as a result the button is not displayed when you only change the avatarbug demo
2150bug.mp4
Solution
Resolved
Attach screenshots or videos demonstrating the changes
2150.mp4