TF-3699 Thread Detail Next previous actions #3843
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/3843. |
dab246
reviewed
Jun 26, 2025
Comment on lines
12
to
63
| void onNext() { | ||
| if (!nextAvailable) return; | ||
|
|
||
| if (isThreadDetailEnabled) { | ||
| final currentThreadIndex = availableThreadIds.indexOf(currentThreadId!); | ||
| final nextThreadIndex = currentThreadIndex + 1; | ||
| final nextThreadId = availableThreadIds[nextThreadIndex]; | ||
| _preparePageWithIndex(nextThreadIndex); | ||
| _goToPageWithEmail( | ||
| currentDisplayedEmails.firstWhereOrNull( | ||
| (presentationEmail) => presentationEmail.threadId == nextThreadId, | ||
| ), | ||
| ); | ||
| return; | ||
| } | ||
|
|
||
| final currentEmailIndex = currentDisplayedEmails.indexOf( | ||
| mailboxDashBoardController.selectedEmail.value!, | ||
| ); | ||
| final nextEmailIndex = currentEmailIndex + 1; | ||
| final nextEmail = currentDisplayedEmails[nextEmailIndex]; | ||
| _preparePageWithIndex(nextEmailIndex); | ||
| _goToPageWithEmail(nextEmail); | ||
| } | ||
|
|
||
| bool get previousAvailable => isThreadDetailEnabled | ||
| ? currentThreadId != availableThreadIds.firstOrNull | ||
| : currentEmailId != currentDisplayedEmails.firstOrNull?.id; | ||
| void onPrevious() { | ||
| if (!previousAvailable) return; | ||
|
|
||
| if (isThreadDetailEnabled) { | ||
| final currentThreadIndex = availableThreadIds.indexOf(currentThreadId!); | ||
| final previousThreadIndex = currentThreadIndex - 1; | ||
| final previousThreadId = availableThreadIds[previousThreadIndex]; | ||
| _preparePageWithIndex(previousThreadIndex); | ||
| _goToPageWithEmail( | ||
| currentDisplayedEmails.firstWhereOrNull( | ||
| (presentationEmail) => presentationEmail.threadId == previousThreadId, | ||
| ), | ||
| ); | ||
| return; | ||
| } | ||
|
|
||
| final currentEmailIndex = currentDisplayedEmails.indexOf( | ||
| mailboxDashBoardController.selectedEmail.value!, | ||
| ); | ||
| final previousEmailIndex = currentEmailIndex - 1; | ||
| final previousEmail = currentDisplayedEmails[previousEmailIndex]; | ||
| _preparePageWithIndex(previousEmailIndex); | ||
| _goToPageWithEmail(previousEmail); | ||
| } |
There was a problem hiding this comment.
Duplicated code, we should improve it
|
dab246
reviewed
Jun 27, 2025
| final threadDetailSettingStatus = ThreadDetailSettingStatus.loading.obs; | ||
| AppLifecycleListener? appLifecycleListener; | ||
| bool threadDetailWasEnabled = true; | ||
|
|
dab246
reviewed
Jun 27, 2025
| ThreadDetailManager(this._getThreadDetailStatusInteractor); | ||
|
|
||
| final availableThreadIds = RxList<ThreadId>(); | ||
| final currentMobilePageViewIndex = 0.obs; |
long-large-emails.webm |
What about with large content in thread ? |
long-large-emails.webm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Demo
Thread setting enable
Web
thread-enable-web.mov
Mobile
thread-enable-mobile.webm
Thread setting disable
Web
thread-disable-web.mov
Mobile
thread-disable-mobile.webm