TF-3835 Fix problems with selecting Italic in fonts on Android #3842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dab246 <tdvu@linagora.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3835
Root cause
Because
document.onselectionchangeis only fired when the selection changes, not when the content or formatting of the selection changes. Whendocument.execCommand('italic')applies the formatting but does not change the selection, soonselectionchangeis not called again.Solution
Use
MutationObserverto listen for DOM changes.Dependency
Resolved
demo-android.webm
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-06-26.at.13.04.05.mp4