TF-3731 Thread Detail Cache web #3840
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/3840. |
dab246
reviewed
Jun 26, 2025
|
|
||
| extension UpdateCachedEmailLoaded on ThreadDetailController { | ||
| void cacheEmailLoaded(EmailId emailId, EmailLoaded emailLoaded) { | ||
| const cacheLimit = 10; |
There was a problem hiding this comment.
why do we only use limit is 10?
There was a problem hiding this comment.
Updated to 20
dab246
reviewed
Jun 26, 2025
Comment on lines
+410
to
+415
| } else if (action is CollapseEmailInThreadDetailAction) { | ||
| if (_currentEmailId == null || action.emailId != _currentEmailId) return; | ||
| for (var worker in obxListeners) { | ||
| worker.dispose(); | ||
| } | ||
| Get.delete<SingleEmailController>(tag: _currentEmailId!.id.value); |
There was a problem hiding this comment.
Please check again memory leak for this case
There was a problem hiding this comment.
Confirmed no memory leak
tddang-linagora
had a problem deploying
to
PR-3840
GitHub Actions
Failure
tddang-linagora
had a problem deploying
to
PR-3840
GitHub Actions
Failure
dab246
force-pushed
the
feature/thread-master-rebased
branch
from
1a46574 to
9aecebb
Compare
tddang-linagora
changed the base branch from
feature/thread-master-rebased
to
feature/thread-master-0.16.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Demo
Screen.Recording.2025-06-26.at.08.53.56.mov