TF-3804 Thread Detail Load selected email in parallel #3813

tddang-linagora · 2025-06-20T03:12:06Z

Issue

[Thread Detail] Optimize content loading #3804

Demo

Screen.Recording.2025-06-20.at.10.07.38.mov

…adata

github-actions · 2025-06-20T03:23:24Z

This PR has been deployed to https://linagora.github.io/tmail-flutter/3813.

...features/thread_detail/presentation/extension/handle_get_email_ids_by_thread_id_success.dart

lib/features/thread_detail/presentation/extension/thread_detail_on_selected_email_updated.dart

…ead metadata

hoangdat · 2025-06-26T09:19:02Z

lib/features/thread_detail/presentation/extension/initialize_thread_detail_emails.dart

+    if (!isThreadDetailEnabled &&
+        selectedEmailId != null &&


should be in a method

tddang-linagora · 2025-06-26T09:22:08Z

lib/features/thread_detail/presentation/extension/thread_detail_on_selected_email_updated.dart

+    consumeState(Stream.value(Right(GetThreadByIdSuccess([
+      selectedEmail!.id!,
+    ]))));
+    consumeState(Stream.value(Right(GetEmailsByIdsSuccess([
+      selectedEmail,
+    ]))));


To follow the original flow of logic of thread.

hoangdat · 2025-06-26T09:27:35Z

lib/features/thread_detail/presentation/extension/thread_detail_on_selected_email_updated.dart

+    consumeState(Stream.value(Right(GetThreadByIdSuccess([
+      selectedEmail!.id!,
+    ]))));


IMO, call this here aren't make sense. It means get thread succeed it then still call it again

should separate it to a method

Suggested change

consumeState(Stream.value(Right(GetThreadByIdSuccess([

selectedEmail!.id!,

]))));

_triggerGetDetailsSelectedEmail();

void _triggerGetDetailsSelectedEmail() { consumeState(Stream.fromIterable([ Right(GetThreadByIdSuccess([selectedEmail!.id!])), Right(GetEmailsByIdsSuccess([selectedEmail])), ])); }

…ead metadata

hoangdat · 2025-06-26T10:00:42Z

lib/features/thread_detail/presentation/extension/thread_detail_on_selected_email_updated.dart

+    consumeState(Stream.fromIterable([
+      Right(PreloadEmailIdsInThreadSuccess([selectedEmail!.id!])),
+      Right(PreloadEmailsByIdsSuccess([selectedEmail])),
+    ]));


Should be in a separate method

hoangdat · 2025-06-26T10:13:18Z

lib/features/thread_detail/presentation/extension/handle_get_emails_by_ids_success.dart

@@ -38,7 +38,7 @@ extension HandleGetEmailsByIdsSuccess on ThreadDetailController {
      );
    }

-    if (!isLoadMore) return;
+    if (!isLoadMore || emailIdsPresentation.length == 1) return;


separate it in method

hoangdat · 2025-06-26T10:28:44Z

lib/features/thread_detail/presentation/extension/initialize_thread_detail_emails.dart

+    if (emailIdsPresentation.length == 1 &&
+        emailIdsPresentation.keys.contains(selectedEmailId)) return;


separate function

hoangdat · 2025-06-26T10:43:47Z

...res/thread_detail/presentation/extension/handle_get_email_ids_by_thread_id_success_test.dart

should add test for failed case handleGetThreadByIdFailure(failure);

hoangdat · 2025-06-26T10:48:49Z

...tures/thread_detail/presentation/extension/thread_detail_on_selected_email_updated_test.dart

+
+    test(
+      'should not reset thread detail controller '
+      'and consume GetThreadByIdSuccess and GetEmailsByIdsSuccess '


should update state for these

…ead metadata

dab246 · 2025-06-27T03:34:39Z

lib/features/thread_detail/presentation/extension/initialize_thread_detail_emails.dart

+  bool _currentThreadOnlyContainsSelectedEmail(EmailId? selectedEmailId) {
+    return emailIdsPresentation.length == 1 &&
+      emailIdsPresentation.keys.contains(selectedEmailId);
+  }


selectedEmailId should be is non-null

emailIdsPresentation is Map<EmailId, PresentationEmail?>, so keys is already List<EmailId>. So if List<EmailId> contains selectedEmailId, by natural selectedEmailId is non-null.

Why is the passed parameter nullable ((EmailId? selectedEmailId) . If it is null we should not check the condition emailIdsPresentation.keys.contains(selectedEmailId)

dab246 · 2025-06-27T04:00:20Z

Email feels like it's flashing when opening, how to fix it?

Screen.Recording.2025-06-27.at.10.56.54.mov

dab246 · 2025-06-27T04:10:06Z

Email subject is duplicated & email is not opened when quick select multiple times, multiple emails on tablet

Screen.Recording.2025-06-27.at.11.08.01.mov

tddang-linagora · 2025-06-27T04:32:06Z

Email feels like it's flashing when opening, how to fix it?

Only way to fix it is making either Thread/get or Email/get full detail wait for the other, which defeats the purpose of this PR.

hoangdat · 2025-06-27T07:10:11Z

Only way to fix it is making either Thread/get or Email/get full detail wait for the other, which defeats the purpose of this PR.

IMO, no problem if waiting Email/get complete, then call Thread/get? WDYT?

…ead metadata

tddang-linagora · 2025-06-27T08:15:03Z

IMO, no problem if waiting Email/get complete, then call Thread/get? WDYT?

Screen.Recording.2025-06-27.at.15.09.38.mov

Email subject is duplicated & email is not opened when quick select multiple times, multiple emails on tablet

Screen.Recording.2025-06-27.at.15.09.16.mov

TF-3804 Thread Detail Load selected email in parallel with thread met…

c2269da

…adata

tddang-linagora requested review from hoangdat and dab246 June 20, 2025 03:12

tddang-linagora self-assigned this Jun 20, 2025

tddang-linagora temporarily deployed to PR-3813 June 20, 2025 03:12 — with GitHub Actions Inactive

dab246 reviewed Jun 20, 2025

View reviewed changes

...features/thread_detail/presentation/extension/handle_get_email_ids_by_thread_id_success.dart Outdated Show resolved Hide resolved

dab246 reviewed Jun 20, 2025

View reviewed changes

...features/thread_detail/presentation/extension/handle_get_email_ids_by_thread_id_success.dart Outdated Show resolved Hide resolved

dab246 reviewed Jun 20, 2025

View reviewed changes

...features/thread_detail/presentation/extension/handle_get_email_ids_by_thread_id_success.dart Outdated Show resolved Hide resolved

dab246 reviewed Jun 20, 2025

View reviewed changes

lib/features/thread_detail/presentation/extension/thread_detail_on_selected_email_updated.dart Outdated Show resolved Hide resolved

fixup! TF-3804 Thread Detail Load selected email in parallel with thr…

5033636

…ead metadata

tddang-linagora temporarily deployed to PR-3813 June 20, 2025 07:30 — with GitHub Actions Inactive

tddang-linagora requested a review from dab246 June 20, 2025 07:30

tddang-linagora linked an issue Jun 23, 2025 that may be closed by this pull request

[Thread Detail] Optimize content loading #3804

Open

1 task

dab246 force-pushed the feature/thread-master-rebased branch from 1a46574 to 9aecebb Compare June 26, 2025 04:44

tddang-linagora changed the base branch from feature/thread-master-rebased to feature/thread-master-0.16.0 June 26, 2025 04:53

hoangdat reviewed Jun 26, 2025

View reviewed changes

tddang-linagora commented Jun 26, 2025

View reviewed changes

hoangdat reviewed Jun 26, 2025

View reviewed changes

fixup! TF-3804 Thread Detail Load selected email in parallel with thr…

f2207f1

…ead metadata

tddang-linagora temporarily deployed to PR-3813 June 26, 2025 09:48 — with GitHub Actions Inactive

fixup! TF-3804 Thread Detail Load selected email in parallel with thr…

acdcada

…ead metadata

tddang-linagora temporarily deployed to PR-3813 June 26, 2025 10:00 — with GitHub Actions Inactive

hoangdat reviewed Jun 26, 2025

View reviewed changes

fixup! TF-3804 Thread Detail Load selected email in parallel with thr…

608ffb7

…ead metadata

tddang-linagora temporarily deployed to PR-3813 June 27, 2025 02:38 — with GitHub Actions Inactive

tddang-linagora requested a review from hoangdat June 27, 2025 02:38

dab246 reviewed Jun 27, 2025

View reviewed changes

tddang-linagora added 2 commits June 27, 2025 14:27

fixup! TF-3804 Thread Detail Load selected email in parallel with thr…

80f2bc7

…ead metadata

fixup! TF-3804 Thread Detail Load selected email in parallel with thr…

de83fa5

…ead metadata

tddang-linagora deployed to PR-3813 June 27, 2025 08:14 — with GitHub Actions View deployment

tddang-linagora requested a review from dab246 June 27, 2025 08:15

		if (emailIdsPresentation.length == 1 &&
		emailIdsPresentation.keys.contains(selectedEmailId)) return;

TF-3804 Thread Detail Load selected email in parallel #3813

Are you sure you want to change the base?

TF-3804 Thread Detail Load selected email in parallel #3813

Uh oh!

Conversation

tddang-linagora commented Jun 20, 2025

Issue

Demo

Uh oh!

github-actions bot commented Jun 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dab246 commented Jun 27, 2025 • edited by tddang-linagora Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dab246 commented Jun 27, 2025 • edited by tddang-linagora Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tddang-linagora commented Jun 27, 2025

Uh oh!

hoangdat commented Jun 27, 2025

Uh oh!

tddang-linagora commented Jun 27, 2025

Uh oh!

Uh oh!

dab246 commented Jun 27, 2025 •

edited by tddang-linagora

Loading

dab246 commented Jun 27, 2025 •

edited by tddang-linagora

Loading