Fix cannot sync data between mobile and web #3750

hoangdat · 2025-05-24T02:41:48Z

Issue

Data between Mobile and Web is not consistent:

Emails lost on mobile when moving emails from one folder to another on the web

Screen.Recording.2025-05-27.at.16.28.24.mov

Resolved

Demo:

Screen.Recording.2025-05-27.at.16.46.35.mov

github-actions · 2025-05-24T02:52:38Z

This PR has been deployed to https://linagora.github.io/tmail-flutter/3750.

dab246 · 2025-06-11T04:55:45Z

Use Isar replace to Hive on mobile

hoangdat · 2025-06-23T03:50:43Z

lib/features/base/upgradeable/upgrade_hive_database_steps_v17.dart

+  @override
+  Future<void> onUpgrade(int oldVersion, int newVersion) async {
+    if (oldVersion > 0 && oldVersion < newVersion && newVersion == 17) {
+      await _cachingManager.clearAll();


so app will be totally logout?

That's right

hoangdat · 2025-06-23T06:48:22Z

lib/features/thread/data/repository/thread_repository_impl.dart

    Properties? updatedProperties,
    List<Email>? emailCacheList
  }) async {
-    if (emailUpdated != null && emailUpdated.isNotEmpty) {
-      if (updatedProperties == null) {
-        return null;
-      }
-      final newEmailUpdated = emailUpdated
-        .map((updatedEmail) => _combineUpdatedWithEmailInCache(updatedEmail, emailCacheList))
-        .where((tuple) => tuple.value2 != null)
-        .map((tuple) => tuple.value2!.combineEmail(tuple.value1, updatedProperties))
-        .toList();
+    if (emailUpdated == null || emailUpdated.isEmpty) return emailUpdated;


should write test to make sure this method work well

hoangdat · 2025-06-23T07:05:50Z

lib/features/email/presentation/utils/email_utils.dart

+      return Properties({
+        ...ThreadConstants.propertiesUpdatedDefault.value,
+        IndividualHeaderIdentifier.headerCalendarEvent.value,
+      });


Suggested change

return Properties({

...ThreadConstants.propertiesUpdatedDefault.value,

IndividualHeaderIdentifier.headerCalendarEvent.value,

});

return ThreadConstants.propertiesCalendarEvent;

hoangdat · 2025-06-23T07:07:05Z

lib/features/caching/config/fcm_isolate_nam_server.dart

fcm_isolate_name_server.dart

lib/features/base/upgradeable/upgrade_hive_database_steps_v17.dart

hoangdat · 2025-06-24T09:11:37Z

lib/features/caching/config/fcm_isolate_name_server.dart

+
+import 'package:hive_ce/hive.dart';
+
+class FcmIsolateNameServer extends IsolateNameServer {


it uses for what?

It is a mechanism for sharing ports between isolates. IsolateNameServer allows registering and looking up a SendPort by name, allowing the secondary isolate to connect to the primary isolate or vice versa without passing the port through the constructor.

Signed-off-by: dab246 <tdvu@linagora.com>

hoangdat temporarily deployed to PR-3750 May 24, 2025 02:41 — with GitHub Actions Inactive

hoangdat temporarily deployed to PR-3750 May 26, 2025 03:22 — with GitHub Actions Inactive

dab246 temporarily deployed to PR-3750 May 27, 2025 04:06 — with GitHub Actions Inactive

dab246 temporarily deployed to PR-3750 May 27, 2025 08:49 — with GitHub Actions Inactive

dab246 force-pushed the hotfix/cannot-sync-data-between-mobile-and-web branch from 4c29be7 to 0d28a19 Compare May 27, 2025 09:48

dab246 temporarily deployed to PR-3750 May 27, 2025 09:49 — with GitHub Actions Inactive

dab246 temporarily deployed to PR-3750 May 28, 2025 10:01 — with GitHub Actions Inactive

dab246 force-pushed the hotfix/cannot-sync-data-between-mobile-and-web branch from 5dd4205 to 45a5db9 Compare May 30, 2025 03:08

dab246 temporarily deployed to PR-3750 May 30, 2025 03:08 — with GitHub Actions Inactive

dab246 temporarily deployed to PR-3750 June 2, 2025 07:37 — with GitHub Actions Inactive

dab246 force-pushed the hotfix/cannot-sync-data-between-mobile-and-web branch from ff53e6e to f32b891 Compare June 11, 2025 08:45

dab246 had a problem deploying to PR-3750 June 11, 2025 08:45 — with GitHub Actions Failure

dab246 had a problem deploying to PR-3750 June 11, 2025 09:00 — with GitHub Actions Failure

dab246 force-pushed the hotfix/cannot-sync-data-between-mobile-and-web branch from f32b891 to 5e39d06 Compare June 12, 2025 04:51

dab246 had a problem deploying to PR-3750 June 12, 2025 04:51 — with GitHub Actions Failure

dab246 had a problem deploying to PR-3750 June 12, 2025 11:15 — with GitHub Actions Failure

dab246 self-assigned this Jun 13, 2025

dab246 force-pushed the hotfix/cannot-sync-data-between-mobile-and-web branch from 5e39d06 to 2327431 Compare June 17, 2025 05:41

dab246 temporarily deployed to PR-3750 June 17, 2025 05:41 — with GitHub Actions Inactive

dab246 self-requested a review June 17, 2025 05:41

dab246 changed the title ~~[WIP-TEST] Hotfix/cannot sync data between mobile and web~~ Fix cannot sync data between mobile and web Jun 17, 2025

dab246 added the cache label Jun 17, 2025

dab246 temporarily deployed to PR-3750 June 17, 2025 10:29 — with GitHub Actions Inactive

dab246 force-pushed the hotfix/cannot-sync-data-between-mobile-and-web branch from 0b8d9e0 to a9133c3 Compare June 18, 2025 02:44

dab246 temporarily deployed to PR-3750 June 18, 2025 02:44 — with GitHub Actions Inactive

dab246 requested a review from tddang-linagora June 18, 2025 07:14

dab246 had a problem deploying to PR-3750 June 18, 2025 10:02 — with GitHub Actions Failure

dab246 temporarily deployed to PR-3750 June 23, 2025 03:36 — with GitHub Actions Inactive

hoangdat commented Jun 23, 2025

View reviewed changes

tddang-linagora reviewed Jun 23, 2025

View reviewed changes

lib/features/base/upgradeable/upgrade_hive_database_steps_v17.dart Outdated Show resolved Hide resolved

dab246 temporarily deployed to PR-3750 June 24, 2025 03:38 — with GitHub Actions Inactive

dab246 requested a review from tddang-linagora June 24, 2025 03:38

tddang-linagora previously approved these changes Jun 24, 2025

View reviewed changes

hoangdat commented Jun 24, 2025

View reviewed changes

hoangdat had a problem deploying to prod June 24, 2025 11:49 — with GitHub Actions Error

hoangdat deployed to prod June 24, 2025 11:49 — with GitHub Actions Active

hoangdat had a problem deploying to prod June 24, 2025 11:49 — with GitHub Actions Failure

hoangdat mentioned this pull request Jun 27, 2025

Bad OIDC error management resulting loosing valid refresh_tokens (mobile app) #3782

Open

dab246 added 10 commits June 27, 2025 16:47

Use default properties when update email from email changed

09ec388

Signed-off-by: dab246 <tdvu@linagora.com>

Remove closeBox when open box in hive database

d12120d

Signed-off-by: dab246 <tdvu@linagora.com>

Increase debounce time receive FCM background message to 30s

b1f0297

Signed-off-by: dab246 <tdvu@linagora.com>

Remove store state to refresh in FCM

33def59

Signed-off-by: dab246 <tdvu@linagora.com>

Auto refresh mails when resume app from background

d6a5eef

Signed-off-by: dab246 <tdvu@linagora.com>

Use Hive CE database to replace Hive database

64a6390

Signed-off-by: dab246 <tdvu@linagora.com>

Fix missing GetStoredEmailStateInteractor

781c4ae

Signed-off-by: dab246 <tdvu@linagora.com>

Fix cannot auto refresh when back to app

274f269

Signed-off-by: dab246 <tdvu@linagora.com>

Add unit test for combineEmailCache method

bcc1a56

Signed-off-by: dab246 <tdvu@linagora.com>

Migrate Hive box To IsolatedHive box

005ac8f

Signed-off-by: dab246 <tdvu@linagora.com>

dab246 dismissed tddang-linagora’s stale review via 005ac8f June 27, 2025 16:56

dab246 force-pushed the hotfix/cannot-sync-data-between-mobile-and-web branch from 561adc8 to 005ac8f Compare June 27, 2025 16:56

dab246 deployed to PR-3750 June 27, 2025 16:56 — with GitHub Actions View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix cannot sync data between mobile and web #3750

Fix cannot sync data between mobile and web #3750

Uh oh!

hoangdat commented May 24, 2025 •

edited by dab246

Loading

Uh oh!

github-actions bot commented May 24, 2025

Uh oh!

dab246 commented Jun 11, 2025 •

edited

Loading

Uh oh!

hoangdat Jun 23, 2025

Uh oh!

dab246 Jun 23, 2025

Uh oh!

hoangdat Jun 23, 2025

Uh oh!

dab246 Jun 24, 2025

Uh oh!

hoangdat Jun 23, 2025

Uh oh!

dab246 Jun 24, 2025

Uh oh!

hoangdat Jun 23, 2025

Uh oh!

dab246 Jun 24, 2025

Uh oh!

Uh oh!

hoangdat Jun 24, 2025

Uh oh!

dab246 Jun 25, 2025

Uh oh!

Uh oh!


		import 'package:hive_ce/hive.dart';

		class FcmIsolateNameServer extends IsolateNameServer {

Fix cannot sync data between mobile and web #3750

Are you sure you want to change the base?

Fix cannot sync data between mobile and web #3750

Uh oh!

Conversation

hoangdat commented May 24, 2025 • edited by dab246 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Resolved

Uh oh!

github-actions bot commented May 24, 2025

Uh oh!

dab246 commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hoangdat commented May 24, 2025 •

edited by dab246

Loading

dab246 commented Jun 11, 2025 •

edited

Loading