Skip to content

TF-45 Abstraction /set method #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2021
Merged

Conversation

hoangdat
Copy link
Member

@hoangdat hoangdat commented Aug 24, 2021

  • abstraction /set method
  • implement email/set

Refs: linagora/tmail-flutter#45

@hoangdat hoangdat self-assigned this Aug 24, 2021
@hoangdat hoangdat force-pushed the set_method branch 3 times, most recently from 387b365 to a929db0 Compare August 25, 2021 12:45
@hoangdat hoangdat marked this pull request as ready for review August 25, 2021 12:46
@hoangdat
Copy link
Member Author

@dab246 please review

@hoangdat hoangdat requested a review from dab246 August 25, 2021 12:48

class SetError with EquatableMixin {
final ErrorType type;
final String? description;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final List<String>? properties;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really?
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really...

Screenshot from 2021-08-27 10-19-29

Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write clear code that is easier to read.

@chibenwa
Copy link
Member

Please write clear code that is easier to read.

How? :-)

@dab246
Copy link
Member

dab246 commented Aug 27, 2021

Please write clear code that is easier to read.

How? :-)

as said

Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok

@hoangdat hoangdat merged commit bc7b368 into linagora:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants