Skip to content

Support custom edit link dialog #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 16, 2024
Merged

Support custom edit link dialog #26

merged 7 commits into from
Jan 16, 2024

Conversation

hieutbui
Copy link
Member

@hieutbui hieutbui commented Jan 10, 2024 •
edited
Loading

Issue

  • As we hardcode the editor's height, the default edit link dialog won't be fully displayed on small screens and editor will also can't scroll down. So we need to support a custom dialog displayed by the application using this library.

Resolved

custom.dialog.mp4

@hieutbui hieutbui force-pushed the improvement/support-custom-edit-link-dialog branch from 354fbb1 to acaeac2 Compare January 12, 2024 09:53
@hieutbui hieutbui changed the title [WIP] Support custom edit link dialog Support custom edit link dialog Jan 12, 2024
@hieutbui hieutbui force-pushed the improvement/support-custom-edit-link-dialog branch 2 times, most recently from 3721bb0 to 0e9988d Compare January 14, 2024 17:58
@hieutbui hieutbui mentioned this pull request Jan 15, 2024
Merged
dab246
dab246 reviewed Jan 15, 2024
View reviewed changes
hoangdat
hoangdat reviewed Jan 15, 2024
View reviewed changes
hoangdat
hoangdat reviewed Jan 15, 2024
View reviewed changes
@dab246
Copy link
Member

dab246 commented Jan 16, 2024

@hieutbui Please rebase it

@hieutbui hieutbui force-pushed the improvement/support-custom-edit-link-dialog branch from 5d6008b to aeadaf0 Compare January 16, 2024 02:25
@dab246 dab246 merged commit 8b88685 into email_supported Jan 16, 2024
@dab246 dab246 mentioned this pull request Apr 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat hoangdat left review comments

@dab246 dab246 dab246 approved these changes

@sherlockvn sherlockvn Awaiting requested review from sherlockvn

@nqhhdev nqhhdev Awaiting requested review from nqhhdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hieutbui @dab246 @hoangdat