🌟 Add read only channel option #2558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oubchid
force-pushed
the
2549
branch
2 times, most recently
from
4c7b20e to
ede2a9e
Compare
RomaricMourgues
suggested changes
Oct 7, 2022
| user_member: {}, | ||
| direct_channel_members: { type: "array" }, | ||
| stats: {}, | ||
| is_readonly: { type: "boolean" }, |
Contributor
There was a problem hiding this comment.
For this to work you must add is_readonly: isWorkspaceAdmin || isChannelOwner to twake/backend/node/src/services/channels/services/channel/service.ts line 143.
RomaricMourgues
pushed a commit
that referenced
this pull request
Oct 9, 2022
* 🌟 Add read only channel option * 🌟 Add read only in channel schema + fix update param * 🌟 Update fr.json * Delete tailwind.css~Stashed changes Co-authored-by: Romaric Mourgues <rmourgues@linagora.com>
github-actions
bot
removed
qa:ready
RomaricMourgues
pushed a commit
that referenced
this pull request
Nov 14, 2022
* 🛠 Fix potential not set cache (#2554) * Fix potential not set cache * Fix minor frontend bug * Fix old mention stuff * 🛠 Minor badge fix * 🔎 Increase thumbnails size (#2556) * 🤖 Update KG sync (#2562) * Fix numbers formats * Make sure messages updates and users updates are sent * Do the same for companies and workspaces * 🛠Fix quote reply css (#2563) * 🌟 Add read only channel option (#2558) * 🌟 Add read only channel option * 🌟 Add read only in channel schema + fix update param * 🌟 Update fr.json * Delete tailwind.css~Stashed changes Co-authored-by: Romaric Mourgues <rmourgues@linagora.com> * 🌟 Forward messages (#2566) * Add forward menu * Fix #2524 * Fix #2524 * Create modal * Finish initial version * Realtime online update * Realtime online update * Fix quoted message display * 🛠 Fix online service typo (#2575) * 🛠 Fix online service typo * Remove code * 🎨 Add checkbox atom and fix avatar atom (#2576) * Add checkbox atom and fix avatar atom * Make onChange optional * Depreciate old checkbox * Fix and add translations * Fix linter * 🛠 Fix ForwardMessages modal not in modal (#2578) * 🎨 Channel settings new UI screens (#2579) * Worked on channel settings new UI screens * Some changes * Update translations and logic * Fix channel icon display * Update back to store in S3 channel thumbnail * Fix linter * Fix int tests * 🛠 Fix backend save image (#2581) * 🌟 New invitation ui (#2577) * 🌟 added invitation ui * 🌟 added allow anyone by email feature * 🌟 add role check * 🌟 add invitation domain checks and implements auto join * 🛠 fixed e2e tests * 🌟 added invite domain checking * 🛠 fixed package-lock * Update changelog.md * Update changelog.md * 📚 Update changelog.md (#2587) * 🛠 2550 fixes (#2591) * Fix all from #2550 * Fix #2549 * Fix const / let * 🛠 Do not return files that doesn't exists anymore (#2592) * Do not return files that doesn't exists anymore * Fix filter * Fix displaying the forwarded message * Fix #2593 * 🛠 Fix scrollbar on Documents (#2599) * 🛠 Fix scrollbar on documents * Fix helpbar * 📚 Testing VitePress for documentation * Fix deployment issue * Fix deployment issue (#2604) * Fix it again Co-authored-by: Oubchid <roubraim@linagora.com> Co-authored-by: Khaled Ferjani <kferjani@linagora.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#2549
Screenshots (if appropriate):
Types of changes
Checklist: