Quicker stateq #225
Merged
Quicker stateq #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In stateq.c I moved the function getmatrix() to before stateq(), which allows its template to be removed from lime.h.
In stateq.c the part of the matrix involving collision coefficients does not depend on the results of getjbar() and thus has been moved outside the loop now starting at line 141 (old line 45) in stateq.c. This results in a slight speedup.
Contributor
|
Late to this party, but couldn't you have done also the collision partner looping in getFixedMatrix? Why do you need to pass on (possibly) several collPartMat which are then summed together when you could've already done that in getFixedMatrix? Am I not seeing something? |
Contributor
Author
|
Good point, never thought of it. Damn you Tuomas, why do you always make me feel so dumb? :) We could also maybe replace the 'Initialize matrix with zeros' with initializing them with the collPart values. |
Contributor
|
Maybe also take lines 90-96 out of getMatrix, as you commented in #177. |
Contributor
|
Anyway, I'll try to cobble up something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In stateq.c the part of the matrix involving collision coefficients does not depend on the results of getjbar() and thus has been moved outside the loop now starting at line 141 (old line 45) in stateq.c. This results in a slight speedup.