Fix for reading in abundance values with gridInFile. #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… malloc'd. Before, in grid2fits.c the grid was malloc'd initially with a call to mallocAndSetDefaultGrid() using nSpecies=0. However, this meant that (*gp).[i].mol was never malloc'd so that later when abundances were read in it would cause a segfault. This is a simple fix that moves nSpecies determination to before the mallocAndSetDefaultGrid() call and passes this as an argument so that (*gp).[i].mol is malloc'd correctly if appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In grid2fits.c: readGridExtFromFits() the grid is malloc'd initially with a call to mallocAndSetDefaultGrid()
using nSpecies=0. However, this means that (*gp).[i].mol is never malloc'd and therefore later when
abundances are read in (block starting line 1155) LIME segfaults. This is a simple fix that moves the nSpecies determination to before the mallocAndSetDefaultGrid() call and passes this as an argument so that (*gp).[i].mol is malloc'd correctly if appropriate. I don't think this breaks anything or causes any unintended behaviour.