Fixes #212 #213
Merged
Fixes #212 #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In raythrucells.c:followRayThroughCells(), *chainOfCellIds and *cellExitIntcpts are now set to NULL before an exit with status==2. This fixes the seg fault. - In raythrucells.c:followRayThroughCells() the pointers are also now freed and set to NULL if none of the calls to buildRayCellChain() returned a zero-valued status. - In raythrucells.c:followRayThroughCells(), any kind of non-zero status will exit with *lenChainPtrs set to 0 and *entryIntcpt set to initial values. - Redundant arguments nSteps and oneOnNSteps deleted from the raytrace.c:traceray_smooth() interface. - In raytrace.c:raytrace(), oneOnNumActiveRaysMinus1 is now set = 1.0/(double)(numActiveRaysInternal-1) to make the raytace percentage go up to 100% again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raythrucells.c:followRayThroughCells(), *chainOfCellIds and *cellExitIntcpts are now set to NULL before an exit with status==2. This fixes the seg fault.
In raythrucells.c:followRayThroughCells() the pointers are also now freed and set to NULL if none of the calls to buildRayCellChain() returned a zero-valued status.
In raythrucells.c:followRayThroughCells(), any kind of non-zero status will exit with *lenChainPtrs set to 0 and *entryIntcpt set to initial values.
Redundant arguments nSteps and oneOnNSteps deleted from the raytrace.c:traceray_smooth() interface.
In raytrace.c:raytrace(), oneOnNumActiveRaysMinus1 is now set = 1.0/(double)(numActiveRaysInternal-1) to make the raytace percentage go up to 100% again.