Warning 나오는 코드 수정

limdongjin · May 2, 2019 · b367672 · b367672
1 parent 45d7b66
commit b367672
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/command_execute.c b/command_execute.c
@@ -354,7 +354,7 @@ shell_status execute_loader(Command *user_command, State *state_store) {
     for(int i = 0; i < 3; i++)
         state_store->debugger_state->filenames[i] = NULL;
 
-    for(int i = 1; i < user_command->token_cnt; i++)
+    for(size_t i= 1; i < user_command->token_cnt; i++)
         state_store->debugger_state->filenames[i - 1] = user_command->tokens[i];
 
     state_store->debugger_state->file_count = user_command->token_cnt - 1;

diff --git a/debug.c b/debug.c
@@ -2,9 +2,10 @@
 
 /* Function Declarations */
 
-bool loader_linker_pass1(Debugger *debugger, Memories *memories);
+bool loader_linker_pass1(Debugger *debugger);
 bool loader_linker_pass2(Debugger *debugger, Memories *memories);
-bool loader_linker_pass1_one(Debugger *debugger, Memories *memories, int file_num, int* csaddr);
+
+bool loader_linker_pass1_one(Debugger *debugger, int file_num, int *csaddr);
 bool loader_linker_pass2_one(Debugger *debugger, Memories *memories, int file_num , int *csaddr);
 LoadInfoList* construct_load_info_list();
 bool destroy_load_info_list(LoadInfoList** load_infos);
@@ -55,7 +56,7 @@ bool loader_linker(Debugger *debugger, Memories *memories){
 
     bool status;
 
-    status = loader_linker_pass1(debugger, memories);
+    status = loader_linker_pass1(debugger);
     if(!status) return false;
 
     status = loader_linker_pass2(debugger, memories);
@@ -76,22 +77,22 @@ bool destroy_load_info_list(LoadInfoList** load_infos){
     return true;
 }
 
-bool loader_linker_pass1(Debugger *debugger, Memories *memories){
+bool loader_linker_pass1(Debugger *debugger) {
     debugger->estab = construct_symbol_table();
     debugger->load_infos = construct_load_info_list();
 
     int csaddr = debugger->start_address;
 
     for(int i = 0; i < debugger->file_count; i++){
         int status;
-        status = loader_linker_pass1_one(debugger, memories, i, &csaddr);
+        status = loader_linker_pass1_one(debugger, i, &csaddr);
         if(!status) return false;
     }
 
     return true;
 }
 
-bool loader_linker_pass1_one(Debugger *debugger, Memories *memories, int file_num, int* csaddr){
+bool loader_linker_pass1_one(Debugger *debugger, int file_num, int *csaddr) {
     assert(file_num >= 0 && file_num <= 2);
     assert(debugger->filenames[file_num]);
 
@@ -263,7 +264,7 @@ bool loader_linker_pass2_one(Debugger *debugger, Memories *memories, int file_nu
 
             sscanf (buf, "M%06X%02X%c%02X", &offset, &length, &op_char, &num);
 
-            if (num == 0xFFFFFFFF){
+            if ((unsigned)num == 0xFFFFFFFF){
                 op_char = '+';
                 num = 0x01;
             }