Skip to content

For IsNFS check all parent directories up to the root until one exist #3835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

For IsNFS check all parent directories up to the root until one exist #3835

merged 1 commit into from
Aug 18, 2025

Conversation

jandubois
Copy link
Member

The current implementation fails if multiple parent directories don't yet exist:

> LIMA_HOME=/path/does/not/exist /limactl ls
FATA[0000] no such file or directory

@jandubois jandubois requested a review from afbjorklund August 14, 2025 18:37
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Aug 18, 2025
AkihiroSuda
AkihiroSuda reviewed Aug 18, 2025
View reviewed changes
AkihiroSuda
AkihiroSuda reviewed Aug 18, 2025
View reviewed changes
@jandubois
For IsNFS check all parent directories up to the root until one exist
58fc7a8 
Signed-off-by: Jan Dubois <jan.dubois@suse.com>
AkihiroSuda
AkihiroSuda approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jandubois jandubois merged commit 876fe29 into lima-vm:master Aug 18, 2025
61 of 63 checks passed
@jandubois jandubois deleted the nfs-check branch August 18, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jandubois @AkihiroSuda