Skip to content

refactor: replace net.ParseIP("0.0.0.0") with net.IPv4zero #3817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

refactor: replace net.ParseIP("0.0.0.0") with net.IPv4zero #3817

merged 1 commit into from
Aug 11, 2025

Conversation

@alexandear
Copy link
Member

@alexandear alexandear commented Aug 11, 2025

https://pkg.go.dev/net#pkg-variables:

var (
	// ...
	IPv4zero      = IPv4(0, 0, 0, 0)         // all zeros
)

@alexandear
refactor: replace net.ParseIP("0.0.0.0") with net.IPv4zero
f507a03 
Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
jandubois
jandubois approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois added this to the v2.0.0 milestone Aug 11, 2025
@jandubois jandubois merged commit 4212a9f into lima-vm:master Aug 11, 2025
88 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jandubois jandubois jandubois approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@alexandear @jandubois