feat: ask to start instance if not running in limactl shell #3337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
requested changes
Mar 11, 2025
Member
jandubois
left a comment
jandubois
left a comment
There was a problem hiding this comment.
LGTM, but please fix lint error.
I assume it complains about the empty line before the if err != nil check.
Signed-off-by: tatucosmin <cosminsebastian2004@gmail.com>
tatucosmin
force-pushed
the
ask-start-shell-confirmation
branch
from
16cce87 to
9b09980
Compare
Contributor
Author
|
sorry for the mess here, just started contributing and getting everything right first try is not so easy 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3336
limactl shell <instance_name>now automatically prompts the user to say if they want to start & connect to the instance via shell