Compatibility with Ubuntu 18.04 LTS (bionic) as a host OS #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `-accel help` writes to stderr, not stdout * `-netdev help` is not implemented The -netdev info is only used to detect vde support, which isn't used on Linux, so this doesn't affect Lima. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
The feature to add algorithms to the front of the default set by using a leading `^` has been added in OpenSSH 8.0 and cause an error on earlier versions. Specifying a different cipher is just a (minor) performance tweak, not a requirement. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
AkihiroSuda
approved these changes
Oct 14, 2021
AkihiroSuda
reviewed
Oct 14, 2021
| if err := cmd.Run(); err != nil { | ||
| logrus.Warnf("failed to run %v: stderr=%q", cmd.Args, stderr.String()) | ||
| } else { | ||
| regex := regexp.MustCompile(`^OpenSSH_(\d+\.\d+)(?:p(\d+))?\b`) |
There was a problem hiding this comment.
Just for the regexp? Then yes, we can move it to a separate function that can be tested without calling ssh -V.
What did you have in mind? Another Cirrus CI task that runs on 18.04 instead of 21.04? Testing just one of the guests, or all of them? I'm kind of wary of adding more CI platforms while the current ones are still flaky. It will just add to the frustration. |
|
I was thinking testing only the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatibility with qemu 2.11.1
-accel helpwrites to stderr, not stdout-netdev helpis not implementedThe
-netdev helpinfo is only used to detect vde support, which isn't used on Linux, so this doesn't affect Lima.Compatibility with OpenSSH 7.1p1
The feature to add algorithms to the front of the default set by using a leading
^has been added in OpenSSH 8.0 and causes an error on earlier versions.Specifying a different cipher is just a (minor) performance tweak, not a requirement.
This PR also moves the SSH info gathering from the init phase to "on demand" when first used. That way the logging system is initialized when the
detect*functions are running.