Skip to content

Make sure to install podman package from repo #2990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Make sure to install podman package from repo #2990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions templates/podman-rootful.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ provision:
script: |
#!/bin/bash
set -eux -o pipefail
command -v podman >/dev/null 2>&1 && exit 0
command -v podman >/dev/null 2>&1 && test -e /etc/lima-podman && exit 0
if [ ! -e /etc/systemd/system/podman.socket.d/override.conf ]; then
mkdir -p /etc/systemd/system/podman.socket.d
cat <<-EOF >/etc/systemd/system/podman.socket.d/override.conf
Expand All @@ -43,7 +43,7 @@ provision:
mkdir -p /etc/tmpfiles.d
echo "d /run/podman 0700 {{.User}} -" > /etc/tmpfiles.d/podman.conf
fi
dnf -y install podman
dnf -y install --best podman && touch /etc/lima-podman
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--best is nice, but touch /etc/lima-podman seems controversial

Copy link
Member

@jandubois jandubois Dec 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how using /etc/lima-podman can create any problems. Every service nowadays seems to store their config in there (including apps, e.g. nanorc or screenrc):

$ lima ls /etc | wc -l
     189

But if you don't like it, how about mkdir -p /var/lib/lima then? I don't really care; I was only pointing out that a temp dir that a user may reasonably wipe clean is a poor location for a file that should never be deleted.

- mode: system
script: |
#!/bin/bash
Expand Down
4 changes: 2 additions & 2 deletions templates/podman.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ provision:
script: |
#!/bin/bash
set -eux -o pipefail
command -v podman >/dev/null 2>&1 && exit 0
dnf -y install podman
command -v podman >/dev/null 2>&1 && test -e /etc/lima-podman && exit 0
dnf -y install --best podman && touch /etc/lima-podman
- mode: user
script: |
#!/bin/bash
Expand Down
Loading