-
Notifications
You must be signed in to change notification settings - Fork 669
Add interface metrics to network settings #2868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, testing it.
By default all additional interfaces use a metric of 100, so take precedence over the builtin SLIRP network. With this commit the metric of each interface can be set separately. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Tested using ramen drenv tool, starting a cluster using ramen k8s based template: Testing defaults
Testing custom metric
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Interface string `yaml:"interface,omitempty" json:"interface,omitempty"` | ||
MACAddress string `yaml:"macAddress,omitempty" json:"macAddress,omitempty"` | ||
Interface string `yaml:"interface,omitempty" json:"interface,omitempty"` | ||
Metric *uint32 `yaml:"metric,omitempty" json:"metric,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
limactl start
now prints
WARN[0000] vmType vz: ignoring networks[0]: [Metric]
Fix lima-vm#2868 Signed-off-by: Jan Dubois <jan.dubois@suse.com>
By default all additional interfaces use a metric of 100, so take precedence over the builtin SLIRP network. With this commit the metric of each interface can be set separately.
Fixes #2867
(It doesn't restore the pre-1.0.0 behaviour, but lets the user restore it themselves, if it is important to them. The new settings still seem like a sensible default).