Skip to content

test.yml: use inject-cmdline-to-template.sh to append no_timer_check kernel command line option - #2541

Merged
AkihiroSuda merged 1 commit into
lima-vm:masterfrom
norio-nomura:use-no_timer_check-kernel-parameter
Aug 18, 2024
Merged

AkihiroSuda merged 1 commit into
lima-vm:masterfrom
norio-nomura:use-no_timer_check-kernel-parameter

Conversation

@norio-nomura

@norio-nomura norio-nomura commented Aug 10, 2024 •

Copy link
Copy Markdown
Contributor

This change aims to avoid kernel panics in the integration tests and the vmnet tests.

==> /Users/runner/.lima/default/serial.log <==
[    0.015000]  setup_IO_APIC+0x2c3/0x370
[    0.015000]  ? enable_IO_APIC+0x1af/0x290
[    0.015000]  apic_intr_mode_init+0x61/0x130
[    0.015000]  x86_late_time_init+0x24/0x40
[    0.015000]  start_kernel+0x2be/0x450
[    0.015000]  x86_64_start_reservations+0x18/0x30
[    0.015000]  x86_64_start_kernel+0xbf/0x110
[    0.015000]  secondary_startup_64_no_verify+0x184/0x18b
[    0.015000]  </TASK>
[    0.015000] ---[ end Kernel panic - not syncing: IO-APIC + timer doesn't work!  Boot with apic=debug and send a report.  Then try booting with the 'noapic' option. ]---

The reason no_timer_check is used instead of noapic, as shown in the kernel panic log, is because I read the following page.
https://lore.kernel.org/all/18354be1-8dba-84f1-bdf5-6821a5013d78@oracle.com/T/

Comment thread examples/default.yaml Outdated
@norio-nomura
norio-nomura force-pushed the use-no_timer_check-kernel-parameter branch from 4937906 to 2410ffa Compare August 17, 2024 03:22
@norio-nomura norio-nomura changed the title default.yaml: Use no_timer_check kernel parameter test.yml: use inject-cmdline-to-template.sh to append no_timer_check kernel command line option Aug 17, 2024
@norio-nomura
norio-nomura marked this pull request as ready for review August 17, 2024 03:51
Comment thread hack/inject-cmdline-to-template.sh
Comment thread .github/workflows/test.yml
…ck` kernel command line option

This change aims to avoid kernel panics in the integration tests and vmnet tests.
```console
==> /Users/runner/.lima/default/serial.log <==
[    0.015000]  setup_IO_APIC+0x2c3/0x370
[    0.015000]  ? enable_IO_APIC+0x1af/0x290
[    0.015000]  apic_intr_mode_init+0x61/0x130
[    0.015000]  x86_late_time_init+0x24/0x40
[    0.015000]  start_kernel+0x2be/0x450
[    0.015000]  x86_64_start_reservations+0x18/0x30
[    0.015000]  x86_64_start_kernel+0xbf/0x110
[    0.015000]  secondary_startup_64_no_verify+0x184/0x18b
[    0.015000]  </TASK>
[    0.015000] ---[ end Kernel panic - not syncing: IO-APIC + timer doesn't work!  Boot with apic=debug and send a report.  Then try booting with the 'noapic' option. ]---
```

The reason `no_timer_check` is used instead of `noapic`, as shown in the kernel panic log, is because I read the following page.
https://lore.kernel.org/all/18354be1-8dba-84f1-bdf5-6821a5013d78@oracle.com/T/

Signed-off-by: Norio Nomura <norio.nomura@gmail.com>

inject-cmdline-to-template.sh: resolve shfmt issue

Signed-off-by: Norio Nomura <norio.nomura@gmail.com>

test.yml: add link to issue

lima-vm#84
Signed-off-by: Norio Nomura <norio.nomura@gmail.com>

inject-cmdline-to-template.sh: add comment lines to explain what this script does

Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
@norio-nomura
norio-nomura force-pushed the use-no_timer_check-kernel-parameter branch from 1541149 to 9fbd193 Compare August 18, 2024 06:41
@AkihiroSuda AkihiroSuda added the area/test Tests and CI label Aug 18, 2024
@AkihiroSuda AkihiroSuda added this to the v0.23.0 milestone Aug 18, 2024

@AkihiroSuda AkihiroSuda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test Tests and CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants