-
Notifications
You must be signed in to change notification settings - Fork 674
Add raw flag #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add raw flag #252
Conversation
Now, the act of # docker for desktop mac
$ /usr/local/bin/docker run -it --rm alpine:latest sh -x -c 'echo $HOME'
+ echo /root
/root
$ alias docker='limactl shell --raw default -- nerdctl'
$ docker run -it --rm alpine:latest sh -x -c 'echo $HOME'
+ echo /root
/root |
Signed-off-by: luyanbo <robert.lyb@alibaba-inc.com>
Signed-off-by: luyanbo <robert.lyb@alibaba-inc.com>
7c683a8
to
6111abf
Compare
@@ -3,8 +3,7 @@ name: test | |||
on: | |||
push: | |||
branches: | |||
- master | |||
- 'release/**' | |||
- '*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think changes to the tests should be mixed into PRs that fix bugs or implement new features, but should be in their own PR.
I'm not sure why you would want to run tests on each push to any branch. I worry that this could use up some Github quota, so other tests may be queued later, instead of being executed right away. Not sure if that is a valid concern though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before creating PR, Github Action cannot be run at forked repo, this causes many PR with failed CI. Except that use branch release/*
to create PR, it looks unreasonable.
The limit of branch to run CI, I think, it's not a good idea.
I just noticed that we did code review discussion in #251 and not here in the PR itself. Are you planning to adapt your PR to that feedback (create a separate |
ping @robberphex |
I'm working on create |
No need to be sorry; I hope you enjoyed your time off! Welcome back! 😄 |
@robberphex Are you still planning to work on this, or do you want somebody else to finish the |
test
on all branch.--raw
flag tolimactl shell
. fix arguments of shell command doesn't support "raw" #251limactl shell
, if debug falg is true, pass-v
to ssh. otherwise, pass-q