Skip to content

Conversation

jandubois
Copy link
Member

Allow explicit override via lima.yaml.

Fixes #1921

Replacement for abandoned #1931

@jandubois
Copy link
Member Author

Note that this PR will modify the timezone setting in existing instances, when they are restarted. I assume this is acceptable, as the timezone should just be a presentation setting.

If this is not acceptable then this PR should wait until we record the Lima version used to create the instance, so only new instances would get new default settings (see #1953 (comment) for how I would implement this).

Allow explicit override via lima.yaml.

Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 6eea9ec into lima-vm:master Dec 25, 2023
@jandubois jandubois deleted the timezone branch December 25, 2023 02:50
@AkihiroSuda
Copy link
Member

vz mode now prints WARN[0001] vmType vz: ignoring [TimeZone] on every start up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Propagate timezone from the host by default (unless --plain is specified)

2 participants