Skip to content

golangci-lint should be run for all build tags, not just for Linux #3585

Closed
@jandubois

Description

@jandubois

Right now only files that are compiled on Linux are checked.

There is currently a macOS specific warning that is not caught by CI:

golangci-lint run ./...
pkg/vz/vz_driver_darwin.go:206:2: directive `//nolint:revive // error-strings` is unused for linter "revive" (nolintlint)
	//nolint:revive // error-strings
	^
1 issues:
* nolintlint: 1

I don't know if we need to run the linter on each platform separately, or if we can simply add something like --build-tags=linux,windows,darwin,386,amd64,arm,arm64 to the commandline (well, this doesn't work; not sure why though).

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions