Skip to content

Fix build and tests #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix build and tests #23

wants to merge 2 commits into from

Conversation

beatgammit
Copy link
Contributor

I removed a bunch of lifetimes (unnecessary?) and used std::thread::Builder instead of std::thread::Thread to get information about panics from the thread.

There's still a bunch of compile warnings, but this at least cleans up the errors.

- use std::thread::Builder to get panic information
@lilyball
Copy link
Owner

The lifetimes are absolutely necessary. They're what keeps you from converting a LuaState to an ExternState and having it outlive the original LuaState. This code just needs to be converted to use a PhantomData marker.

I already have the conversion done locally, but I'm waiting for rust-lang/rust#22749 (since I also converted the build script to use std::process and it's currently broken).

@beatgammit
Copy link
Contributor Author

The lifetimes are absolutely necessary... This code just needs to be converted to use a PhantomData marker.

Ok, that makes sense. I wasn't 100% sure about removing the lifetimes because of all of the unsafe transmute blocks. Good to know you're already on it!

but I'm waiting for rust-lang/rust#22749

Awesome, that was quick!

@beatgammit beatgammit closed this Feb 24, 2015
@lilyball
Copy link
Owner

I just pushed my changes. Turns out that if I don't set stdout/stderr at all, it will default to inherit, so I don't actually have to wait for rust-lang/rust#22749.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants