Skip to content

Commit

Permalink
refactor: use ReturnType<typeof setTimeout> instead of `NodeJS.Time…
Browse files Browse the repository at this point in the history
…out` (alibaba#1384)
  • Loading branch information
keqingrong authored Dec 15, 2021
1 parent d84a254 commit 322a381
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 8 deletions.
2 changes: 1 addition & 1 deletion packages/hooks/src/useLongPress/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function useLongPress(
) {
const onLongPressRef = useLatest(onLongPress);

const timerRef = useRef<NodeJS.Timeout>();
const timerRef = useRef<ReturnType<typeof setTimeout>>();
const isTriggeredRef = useRef(false);

useEffectWithTarget(
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { useRef } from 'react';
import type { Plugin } from '../types';
import type { Plugin, Timeout } from '../types';

const useLoadingDelayPlugin: Plugin<any, any[]> = (fetchInstance, { loadingDelay }) => {
const timerRef = useRef<NodeJS.Timeout>();
const timerRef = useRef<Timeout>();

if (!loadingDelay) {
return {};
Expand Down
4 changes: 2 additions & 2 deletions packages/hooks/src/useRequest/src/plugins/usePollingPlugin.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import { useRef } from 'react';
import useUpdateEffect from '../../../useUpdateEffect';
import type { Plugin } from '../types';
import type { Plugin, Timeout } from '../types';
import isDocumentVisible from '../utils/isDocumentVisible';
import subscribeReVisible from '../utils/subscribeReVisible';

const usePollingPlugin: Plugin<any, any[]> = (
fetchInstance,
{ pollingInterval, pollingWhenHidden = true },
) => {
const timerRef = useRef<NodeJS.Timeout>();
const timerRef = useRef<Timeout>();
const unsubscribeRef = useRef<() => void>();

const stopPolling = () => {
Expand Down
4 changes: 2 additions & 2 deletions packages/hooks/src/useRequest/src/plugins/useRetryPlugin.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { useRef } from 'react';
import type { Plugin } from '../types';
import type { Plugin, Timeout } from '../types';

const useRetryPlugin: Plugin<any, any[]> = (fetchInstance, { retryInterval, retryCount }) => {
const timerRef = useRef<NodeJS.Timeout>();
const timerRef = useRef<Timeout>();
const countRef = useRef(0);

const triggerByRetry = useRef(false);
Expand Down
2 changes: 2 additions & 0 deletions packages/hooks/src/useRequest/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -116,3 +116,5 @@ export interface Result<TData, TParams extends any[]> {
runAsync: Fetch<TData, TParams>['runAsync'];
mutate: Fetch<TData, TParams>['mutate'];
}

export type Timeout = ReturnType<typeof setTimeout>;
2 changes: 1 addition & 1 deletion packages/hooks/src/useWebSocket/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export default function useWebSocket(socketUrl: string, options: Options = {}):
const onErrorRef = useLatest(onError);

const reconnectTimesRef = useRef(0);
const reconnectTimerRef = useRef<NodeJS.Timeout>();
const reconnectTimerRef = useRef<ReturnType<typeof setTimeout>>();
const websocketRef = useRef<WebSocket>();

const unmountedRef = useRef(false);
Expand Down

0 comments on commit 322a381

Please sign in to comment.