Skip to content

Commit

Permalink
window list applet: Don't display windows with skip-taskbar set.
Browse files Browse the repository at this point in the history
I kind of think this should be addressed in Main.isWindowInteresting and
the check removed from CinnamonWindowTracker - in the main function, we
check the tracker, but only return there if the return is TRUE.  Dialog
windows with skip-taskbar set (which is common) end up being shown,
because they're not app-backed windows. The skip-taskbar hint should be
respected regardless.

Removing the check from the window tracker function would require changes
to not only windowAttentionHandler but also any xlets that make use of
either the main or the window tracker functions.  And since other entities
such as alt-tab and the quick list applet already do their own skip-taskbar
check, just fixing the window list is ok.
  • Loading branch information
mtwebster committed Oct 21, 2018
1 parent ea4446e commit a884e72
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1117,7 +1117,7 @@ class CinnamonWindowListApplet extends Applet.Applet {
_onWindowSkipTaskbarChanged(screen, metaWindow) {
let window = this._windows.find(win => (win.metaWindow == metaWindow));

if (window && !Main.isInteresting(metaWindow)) {
if (window && window.is_skip_taskbar()) {
this._removeWindow(metaWindow);
return;
}
Expand Down Expand Up @@ -1279,6 +1279,7 @@ class CinnamonWindowListApplet extends Applet.Applet {

_shouldAdd(metaWindow) {
return Main.isInteresting(metaWindow) &&
!metaWindow.is_skip_taskbar() &&
this._monitorWatchList.indexOf(metaWindow.get_monitor()) != -1;
}

Expand Down

0 comments on commit a884e72

Please sign in to comment.