Skip to content

remove restriction on version of doctrine/persistence#170

Merged
alexislefebvre merged 2 commits intoliip:2.xfrom
alexislefebvre:remove-restriction-on-doctrine/persistence-version
Jan 31, 2022
Merged

remove restriction on version of doctrine/persistence#170
alexislefebvre merged 2 commits intoliip:2.xfrom
alexislefebvre:remove-restriction-on-doctrine/persistence-version

Conversation

@alexislefebvre
Copy link
Collaborator

Follow up of #169, revert a change that should not be needed, but is required to run tests.

Any help is welcome.

@alexislefebvre alexislefebvre marked this pull request as draft January 12, 2022 20:09
@alexislefebvre alexislefebvre added the help wanted Extra attention is needed label Jan 14, 2022
@alexislefebvre alexislefebvre force-pushed the remove-restriction-on-doctrine/persistence-version branch from c8f8212 to 8b084bd Compare January 31, 2022 14:40
@alexislefebvre alexislefebvre force-pushed the remove-restriction-on-doctrine/persistence-version branch from 74f8def to 70aec67 Compare January 31, 2022 14:56
@alexislefebvre alexislefebvre marked this pull request as ready for review January 31, 2022 14:57
@alexislefebvre
Copy link
Collaborator Author

doctrine/persistence 2.3.0 removed the dependency on doctrine/annotations: https://github.com/doctrine/persistence/pull/197/files

So it was missing and the call to the annotations.reader service was broken.

@alexislefebvre alexislefebvre merged commit 8de8e23 into liip:2.x Jan 31, 2022
@alexislefebvre alexislefebvre deleted the remove-restriction-on-doctrine/persistence-version branch January 31, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant