LS Metrics SDK: Use the OTel Collector pdata libraries, batch processor, and OTLP exporter
#445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The client-side TLS support which ought to work simply b/c it's a collector component (that is tested elsewhere), but I'm having trouble in these tests: have left TODOs mentioning this loss of test coverage (i.e., LS metrics SDK w/ TLS settings). (Note Lightstep does not use TLS settings internally.) |
kristinapathak
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This replaces the OTLP gRPC exporter which was originally forked from the OTel-Go repository, with a new custom implementation based on the OTel Collector batch processor (acting as a "splitter") and the OTel Collector OTLP exporter (actually, the OTel-Arrow variant).
Link to tracking Issue: #263
Testing: New test coverage.
Documentation: Added.