Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New runtime/metrics instrumentation #267

Merged
merged 7 commits into from
Sep 2, 2022
Merged

New runtime/metrics instrumentation #267

merged 7 commits into from
Sep 2, 2022

Conversation

jmacd
Copy link
Member

@jmacd jmacd commented Sep 1, 2022

Description:
Uses the new-since go-1.16 runtime/metrics package to generate metrics, intended to replace the otel-go-contrib instrumentation/runtime package.

Link to tracking Issue:
Part of #257. Part of #270.

Testing: Full coverage.

Documentation: doc.go lists the metrics generated as of go-1.19. This does not build prior to go-1.18.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Base: 94.06% // Head: 93.63% // Decreases project coverage by -0.42% ⚠️

Coverage data is based on head (4e6791f) compared to base (9f0728e).
Patch coverage: 81.60% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   94.06%   93.63%   -0.43%     
==========================================
  Files          67       68       +1     
  Lines        3538     3663     +125     
==========================================
+ Hits         3328     3430     +102     
- Misses        161      181      +20     
- Partials       49       52       +3     
Impacted Files Coverage Δ
lightstep/instrumentation/runtime/builtin.go 81.60% <81.60%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic add, excited to get this in our codebase!

@jmacd jmacd merged commit 4b4be81 into main Sep 2, 2022
@jmacd jmacd deleted the jmacd/newruntimepkg branch September 2, 2022 19:55
@jmacd jmacd mentioned this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants